Skip to content

Commit 0a68e56

Browse files
authored
samples: pull in latest typeless bot, clean up some comments (#1698)
samples: pull in latest typeless bot, clean up some comments
1 parent 520c18d commit 0a68e56

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

docker/owlbot/nodejs/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
4848
# * gts/typescript are used for linting.
4949
# * google-gax is used for compiling protos.
5050
RUN cd /synthtool && mkdir node_modules && npm i gts@3.1.0 google-gax@3.5.2 \
51-
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.2
51+
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.3
5252

5353
ENTRYPOINT [ "/bin/bash" ]
5454
CMD [ "/synthtool/docker/owlbot/nodejs/entrypoint.sh" ]

docker/owlbot/nodejs_mono_repo/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ RUN find /synthtool -type d -exec chmod a+x {} \;
4848
# * gts/typescript are used for linting.
4949
# * google-gax is used for compiling protos.
5050
RUN cd /synthtool && mkdir node_modules && npm i gts@3.1.0 google-gax@3.5.2 \
51-
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.2
51+
typescript@4.7.4 @google-cloud/typeless-sample-bot@1.0.3
5252

5353
ENTRYPOINT [ "/bin/bash" ]
5454
CMD [ "/synthtool/docker/owlbot/nodejs_mono_repo/entrypoint.sh" ]

synthtool/languages/node.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,15 @@ def install(hide_output=False):
176176
shell.run(["npm", "install"], hide_output=hide_output)
177177

178178

179-
# This is currently an optional, opt-in part of an individual repo's
180-
# OwlBot.py, and must be called from there before calling owlbot_main.
181179
def typeless_samples_hermetic(hide_output=False):
182180
"""
183181
Converts TypeScript samples in the current Node.js library
184182
to JavaScript samples. Run this step before fix() and friends.
185183
Assumes that typeless-sample-bot is already installed in a well
186184
known location on disk (node_modules/.bin).
185+
186+
This is currently an optional, opt-in part of an individual repo's
187+
OwlBot.py, and must be called from there before calling owlbot_main.
187188
"""
188189
logger.debug("Run typeless sample bot")
189190
shell.run(

synthtool/languages/node_mono_repo.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,14 +221,15 @@ def install(hide_output=False):
221221
shell.run(["npm", "install"], hide_output=hide_output)
222222

223223

224-
# This is currently an optional, opt-in part of an individual repo's
225-
# OwlBot.py, and must be called from there before calling owlbot_main.
226224
def typeless_samples_hermetic(hide_output=False):
227225
"""
228226
Converts TypeScript samples in the current Node.js library
229227
to JavaScript samples. Run this step before fix() and friends.
230228
Assumes that typeless-sample-bot is already installed in a well
231229
known location on disk (node_modules/.bin).
230+
231+
This is currently an optional, opt-in part of an individual repo's
232+
OwlBot.py, and must be called from there before calling owlbot_main.
232233
"""
233234
logger.debug("Run typeless sample bot")
234235
shell.run(

0 commit comments

Comments
 (0)