Skip to content

Commit e1d52a8

Browse files
committed
Fix regression in .
1 parent 12ac983 commit e1d52a8

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

gcloud/datastore/test_transaction.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def test_rollback(self):
105105
xact.begin()
106106
xact.rollback()
107107
self.assertEqual(xact.id, None)
108-
self.assertEqual(connection._rolled_back, _DATASET)
108+
self.assertEqual(connection._rolled_back, (_DATASET, 234))
109109

110110
def test_commit_no_auto_ids(self):
111111
_DATASET = 'DATASET'
@@ -159,7 +159,7 @@ class Foo(Exception):
159159
raise Foo()
160160
except Foo:
161161
self.assertEqual(xact.id, None)
162-
self.assertEqual(connection._rolled_back, _DATASET)
162+
self.assertEqual(connection._rolled_back, (_DATASET, 234))
163163
self.assertEqual(connection._committed, None)
164164
self.assertEqual(xact.id, None)
165165

@@ -187,8 +187,8 @@ def begin_transaction(self, dataset_id):
187187
self._begun = dataset_id
188188
return self._xact_id
189189

190-
def rollback(self, dataset_id):
191-
self._rolled_back = dataset_id
190+
def rollback(self, dataset_id, transaction_id):
191+
self._rolled_back = dataset_id, transaction_id
192192

193193
def commit(self, dataset_id, mutation):
194194
self._committed = (dataset_id, mutation)

gcloud/datastore/transaction.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def rollback(self):
140140
- Sets the current connection's transaction reference to None.
141141
- Sets the current transaction's ID to None.
142142
"""
143-
self.connection.rollback(self._dataset_id)
143+
self.connection.rollback(self._dataset_id, self._id)
144144
self._id = None
145145

146146
def commit(self):

0 commit comments

Comments
 (0)