Skip to content

feat(o11y): introduce observability flags needed within the generator - #9052

Merged
shivanee-p merged 9 commits into
mainfrom
shivaneep-o11y-flag
Aug 15, 2026
Merged

feat(o11y): introduce observability flags needed within the generator#9052
shivanee-p merged 9 commits into
mainfrom
shivaneep-o11y-flag

Conversation

@shivanee-p

@shivanee-p shivanee-p commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds support for the o11y feature flag to gapic-generator-typescript

  • Added enableTelemetryTracing flag parsing (enable_telemetry_tracing=true)
  • Added enableTelemetryTracing option support to API schema and Naming options
  • Added corresponding unit tests
  • Created unit tests for the generator

@shivanee-p
shivanee-p requested a review from a team as a code owner July 31, 2026 20:38
@github-actions
github-actions Bot requested a review from feywind July 31, 2026 20:38
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 31, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for an enableTelemetryTracing option across the generator, schema, and client interface packages, including adding the option to ClientOptions and introducing an InternalTelemetry interface. Feedback suggests updating the parameter parsing in the generator to support both hyphenated and snake_case parameter names for consistency with other flags, and to only set the property to true when explicitly configured.

Comment thread core/generator/gapic-generator-typescript/typescript/src/generator.ts
westarle
westarle reviewed Aug 3, 2026
View reviewed changes
Comment thread core/generator/gapic-generator-typescript/typescript/src/generator.ts
Comment thread core/generator/gapic-generator-typescript/typescript/src/generator.ts Outdated
Comment thread core/packages/gax/src/clientInterface.ts
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch 2 times, most recently from c7259a4 to 4159976 Compare August 4, 2026 03:22
@shivanee-p
shivanee-p requested a review from westarle August 4, 2026 04:03
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch from 77b4eaf to 048fff3 Compare August 14, 2026 20:55
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch from a27b286 to 78c2295 Compare August 14, 2026 22:54
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch from 47c98d3 to 019323f Compare August 14, 2026 23:04
@shivanee-p
shivanee-p merged commit 849708b into main Aug 15, 2026
45 checks passed
@shivanee-p
shivanee-p deleted the shivaneep-o11y-flag branch August 15, 2026 00:35
@release-please release-please Bot mentioned this pull request Aug 15, 2026
Merged
danieljbruce pushed a commit that referenced this pull request Aug 24, 2026
@release-please
chore: release main (#9142)
fc7a726 
🤖 I have created a release *beep* *boop*
---


<details><summary>gapic-generator: 5.1.0</summary>

##
[5.1.0](gapic-generator-v5.0.1...gapic-generator-v5.1.0)
(2026-08-20)


### Features

* **o11y:** Introduce observability flags needed within the generator
([#9052](#9052))
([849708b](849708b))
</details>

<details><summary>google-gax: 6.0.3</summary>

##
[6.0.3](google-gax-v6.0.2...google-gax-v6.0.3)
(2026-08-20)


### Bug Fixes

* Validate path parameters and prevent traversal/injection in REST
transcoder - tests relocated
([#9166](#9166))
([8a2b491](8a2b491))
* Validate path parameters and prevent traversal/injection in REST
transcoder
([#9151](#9151))
([0152a8e](0152a8e))
</details>

<details><summary>gaxios: 8.0.0</summary>

##
[8.0.0](gaxios-v7.3.1...gaxios-v8.0.0)
(2026-08-20)


### ⚠ BREAKING CHANGES

* Update gaxios to minimum Node version of 22.
([#9172](#9172))

### Features

* Update gaxios to minimum Node version of 22.
([#9172](#9172))
([20f9fbd](20f9fbd))
</details>

<details><summary>precise-date: 6.0.1</summary>

##
[6.0.1](precise-date-v6.0.0...precise-date-v6.0.1)
(2026-08-20)


### Bug Fixes

* **precise-date:** Support TypeScript 7
([#9115](#9115))
([1cdce29](1cdce29))
</details>

<details><summary>admanager: 0.10.0</summary>

##
[0.10.0](admanager-v0.9.0...admanager-v0.10.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>chat: 0.30.0</summary>

##
[0.30.0](chat-v0.29.0...chat-v0.30.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>aiplatform: 7.2.0</summary>

##
[7.2.0](aiplatform-v7.1.0...aiplatform-v7.2.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>alloydb: 3.1.0</summary>

##
[3.1.0](alloydb-v3.0.0...alloydb-v3.1.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>auditmanager: 0.3.0</summary>

##
[0.3.0](auditmanager-v0.2.0...auditmanager-v0.3.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>bigquery-reservation: 5.1.0</summary>

##
[5.1.0](bigquery-reservation-v5.0.0...bigquery-reservation-v5.1.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>google-cloud-bigquery-storage-api: 0.4.0</summary>

##
[0.4.0](google-cloud-bigquery-storage-api-v0.3.0...google-cloud-bigquery-storage-api-v0.4.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>google-cloud-bigtable-api: 0.4.0</summary>

##
[0.4.0](google-cloud-bigtable-api-v0.3.0...google-cloud-bigtable-api-v0.4.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>dataform: 3.2.0</summary>

##
[3.2.0](dataform-v3.1.0...dataform-v3.2.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>dialogflow-cx: 6.0.1</summary>

##
[6.0.1](dialogflow-cx-v6.0.0...dialogflow-cx-v6.0.1)
(2026-08-20)


### Bug Fixes

* Validate path parameters and prevent traversal/injection in REST
transcoder
([#9151](#9151))
([0152a8e](0152a8e))
</details>

<details><summary>ftp: 0.1.0</summary>

## 0.1.0 (2026-08-20)


### Features

* **google/cloud/ftp/v1:** Onboard a new library
([#9147](#9147))
([6317bd9](6317bd9))


### Bug Fixes

* Update ftp config
([#9156](#9156))
([ea818ba](ea818ba))
</details>

<details><summary>oracledatabase: 0.10.0</summary>

##
[0.10.0](oracledatabase-v0.9.0...oracledatabase-v0.10.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>recaptcha-enterprise: 7.1.0</summary>

##
[7.1.0](recaptcha-enterprise-v7.0.0...recaptcha-enterprise-v7.1.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>retail: 5.1.0</summary>

##
[5.1.0](retail-v5.0.1...retail-v5.1.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>publicca: 3.1.0</summary>

##
[3.1.0](publicca-v3.0.0...publicca-v3.1.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>support: 3.1.0</summary>

##
[3.1.0](support-v3.0.0...support-v3.1.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>vectorsearch: 0.10.0</summary>

##
[0.10.0](vectorsearch-v0.9.0...vectorsearch-v0.10.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

<details><summary>workloadidentity: 0.1.0</summary>

## 0.1.0 (2026-08-20)


### Features

* **google/cloud/workloadidentity/v1:** Onboard a new library
([#9143](#9143))
([7a22218](7a22218))


### Bug Fixes

* **workloadidentity:** Update release level to preview
([#9161](#9161))
([69829c9](69829c9)),
refs
[#9096](#9096)
</details>

<details><summary>developer-knowledge: 0.5.0</summary>

##
[0.5.0](developer-knowledge-v0.4.0...developer-knowledge-v0.5.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>health: 0.6.0</summary>

##
[0.6.0](health-v0.5.0...health-v0.6.0)
(2026-08-20)


### Features

* Update sources and regenerate
([#9170](#9170))
([827fab0](827fab0))
</details>

<details><summary>cloudbuild: 6.1.0</summary>

##
[6.1.0](cloudbuild-v6.0.0...cloudbuild-v6.1.0)
(2026-08-20)


### Features

* Update API sources and regenerate
([#9140](#9140))
([863bc96](863bc96))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westarle westarle westarle approved these changes
@feywind feywind Awaiting requested review from feywind
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivanee-p @westarle