Skip to content

feat(google/cloud/commerceproducer/v1beta): onboard a new library - #8940

Merged
quirogas merged 1 commit into
googleapis:mainfrom
quirogas:chore-onboard-library-2026-07-22-google/cloud/commerceproducer/v1beta
Jul 22, 2026
Merged

quirogas merged 1 commit into
googleapis:mainfrom
quirogas:chore-onboard-library-2026-07-22-google/cloud/commerceproducer/v1beta

Conversation

@quirogas

@quirogas quirogas commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b/533114673

@quirogas quirogas self-assigned this Jul 22, 2026
@quirogas
quirogas marked this pull request as ready for review July 22, 2026 22:07
@quirogas
quirogas requested a review from a team as a code owner July 22, 2026 22:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Node.js client library package, @google-cloud/commerceproducer, for the Cloud Commerce Producer API, including its protocol buffers, auto-generated client code, samples, and configuration files. The review feedback suggests improving the package description and keywords in package.json to enhance clarity and discoverability on npm.

{
"name": "@google-cloud/commerceproducer",
"version": "0.1.0",
"description": "Commerceproducer client for Node.js",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package description could be more descriptive to improve clarity and discoverability on npm. A more descriptive name that aligns with other metadata files would be beneficial.

For example, Cloud Commerce Producer API client for Node.js would be more informative and consistent with the name_pretty in .repo-metadata.json and the title in README.md.

Suggested change
"description": "Commerceproducer client for Node.js",
"description": "Cloud Commerce Producer API client for Node.js",

"google cloud platform",
"google cloud",
"cloud",
"google commerceproducer",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve discoverability on npm, consider adding the full pretty name of the API, "Cloud Commerce Producer", to the keywords.

Suggested change
"google commerceproducer",
"google commerceproducer",
"Cloud Commerce Producer",

@quirogas
quirogas merged commit d49517d into googleapis:main Jul 22, 2026
35 of 36 checks passed
@release-please release-please Bot mentioned this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants