feat(google/cloud/productregistry/v1): onboard a new library - #8834
Merged
quirogas merged 4 commits intoJul 9, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/productregistry package to the monorepo, including its configuration, proto definitions, generated client library, samples, and tests. The review feedback suggests two improvements in package.json: updating the repository field to use the full object format with a directory property to correctly reflect its location in the monorepo, and correcting the Node.js engine version format from '>=v18' to '>=18' to comply with standard semver formatting.
Onboard the Cloud Product Registry API (google/cloud/productregistry/v1) to the Node.js monorepo using Librarian. Verify generated client structure, proto definitions, and test suite. Coordinate npm release publishing upon merge. For b/530253862
quirogas
force-pushed
the
chore-onboard-library-b530253862-google-cloud-productregistry
branch
from
July 9, 2026 16:21
d1933c0 to
832c212
Compare
…-b530253862-google-cloud-productregistry # Conflicts: # .release-please-manifest.json # librarian.yaml # release-please-config.json
quirogas
marked this pull request as ready for review
July 9, 2026 18:25
danieljbruce
approved these changes
Jul 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For b/530253862