Skip to content

Commit e68af4d

Browse files
authored
fix(deps): update dependency @google-cloud/common to ^0.23.0 and logging. (#152)
Update @google-cloud/logging@ to 3.0.2. Move common to devDependencies. It is only used in errors-transport system tests. Fixes: googleapis/nodejs-logging-winston#151
1 parent 69c819a commit e68af4d

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

handwritten/nodejs-logging-winston/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@
7373
"posttest": "npm run check"
7474
},
7575
"dependencies": {
76-
"@google-cloud/common": "^0.21.1",
77-
"@google-cloud/logging": "^3.0.1",
76+
"@google-cloud/logging": "^3.0.2",
7877
"@sindresorhus/is": "^0.10.0",
7978
"lodash.mapvalues": "^4.6.0"
8079
},
8180
"devDependencies": {
81+
"@google-cloud/common": "^0.23.0",
8282
"@google-cloud/nodejs-repo-tools": "^2.3.0",
8383
"@types/glob": "^5.0.35",
8484
"@types/is": "0.0.20",
@@ -111,6 +111,7 @@
111111
"post-install-check": "0.0.1",
112112
"prettier": "^1.13.6",
113113
"proxyquire": "^2.0.1",
114+
"request": "^2.88.0",
114115
"rimraf": "^2.6.2",
115116
"source-map-support": "^0.5.6",
116117
"tmp": "0.0.33",

handwritten/nodejs-logging-winston/system-test/errors-transport.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616

1717
import * as common from '@google-cloud/common';
18+
import * as request from 'request';
1819
const packageJson = require('../../package.json');
1920

2021
export interface ServiceContext {
@@ -46,7 +47,8 @@ export class ErrorsApiTransport extends common.Service {
4647
super({
4748
baseUrl: 'https://clouderrorreporting.googleapis.com/v1beta1',
4849
scopes: ['https://www.googleapis.com/auth/cloud-platform'],
49-
packageJson
50+
packageJson,
51+
requestModule: request
5052
});
5153
}
5254

0 commit comments

Comments
 (0)