Skip to content

Commit c786850

Browse files
ericuldallericuldall
committed
updated FQDN's to googleapis.com with a trailing dot resulting in googleapis.com.
1 parent 184f9bb commit c786850

64 files changed

Lines changed: 174 additions & 174 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.jscsrc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
],
1717
"requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties",
1818
"maximumLineLength": {
19-
"value": 80,
19+
"value": 81,
2020
"allowUrlComments": true
2121
},
2222
"excludeFiles": [

‎packages/bigquery/src/index.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ function BigQuery(options) {
6666
}
6767

6868
var config = {
69-
baseUrl: 'https://www.googleapis.com/bigquery/v2',
70-
scopes: ['https://www.googleapis.com/auth/bigquery'],
69+
baseUrl: 'https://www.googleapis.com./bigquery/v2',
70+
scopes: ['https://www.googleapis.com./auth/bigquery'],
7171
packageJson: require('../package.json')
7272
};
7373

‎packages/bigquery/src/table.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ Table.prototype.createWriteStream = function(metadata) {
548548
},
549549
request: {
550550
uri: format('{base}/{projectId}/jobs', {
551-
base: 'https://www.googleapis.com/upload/bigquery/v2/projects',
551+
base: 'https://www.googleapis.com./upload/bigquery/v2/projects',
552552
projectId: self.bigQuery.projectId
553553
})
554554
}

‎packages/bigquery/test/index.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,10 @@ describe('BigQuery', function() {
144144

145145
var calledWith = bq.calledWith_[0];
146146

147-
var baseUrl = 'https://www.googleapis.com/bigquery/v2';
147+
var baseUrl = 'https://www.googleapis.com./bigquery/v2';
148148
assert.strictEqual(calledWith.baseUrl, baseUrl);
149149
assert.deepEqual(calledWith.scopes, [
150-
'https://www.googleapis.com/auth/bigquery'
150+
'https://www.googleapis.com./auth/bigquery'
151151
]);
152152
assert.deepEqual(calledWith.packageJson, require('../package.json'));
153153
});

‎packages/bigquery/test/table.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ describe('BigQuery/Table', function() {
665665

666666
it('should pass the correct request uri', function(done) {
667667
makeWritableStreamOverride = function(stream, options) {
668-
var uri = 'https://www.googleapis.com/upload/bigquery/v2/projects/' +
668+
var uri = 'https://www.googleapis.com./upload/bigquery/v2/projects/' +
669669
table.bigQuery.projectId + '/jobs';
670670
assert.equal(options.request.uri, uri);
671671
done();

‎packages/bigtable/src/index.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ function Bigtable(options) {
309309
return new Bigtable(options);
310310
}
311311

312-
var baseUrl = 'bigtable.googleapis.com';
313-
var adminBaseUrl = 'bigtableadmin.googleapis.com';
312+
var baseUrl = 'bigtable.googleapis.com.';
313+
var adminBaseUrl = 'bigtableadmin.googleapis.com.';
314314

315315
var customEndpoint = options.apiEndpoint ||
316316
process.env.BIGTABLE_EMULATOR_HOST;
@@ -345,9 +345,9 @@ function Bigtable(options) {
345345
}
346346
},
347347
scopes: [
348-
'https://www.googleapis.com/auth/bigtable.admin',
349-
'https://www.googleapis.com/auth/bigtable.data',
350-
'https://www.googleapis.com/auth/cloud-platform'
348+
'https://www.googleapis.com./auth/bigtable.admin',
349+
'https://www.googleapis.com./auth/bigtable.data',
350+
'https://www.googleapis.com./auth/cloud-platform'
351351
],
352352
packageJson: require('../package.json')
353353
};

‎packages/bigtable/test/index.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,38 +136,38 @@ describe('Bigtable', function() {
136136

137137
var calledWith = bigtable.calledWith_[0];
138138

139-
assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com');
139+
assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com.');
140140
assert.strictEqual(calledWith.service, 'bigtable');
141141
assert.strictEqual(calledWith.apiVersion, 'v2');
142142
assert.strictEqual(calledWith.customEndpoint, false);
143143

144144
assert.deepEqual(calledWith.protoServices, {
145145
Bigtable: googleProtoFiles('bigtable/v2/bigtable.proto'),
146146
BigtableTableAdmin: {
147-
baseUrl: 'bigtableadmin.googleapis.com',
147+
baseUrl: 'bigtableadmin.googleapis.com.',
148148
path: googleProtoFiles(
149149
'bigtable/admin/v2/bigtable_table_admin.proto'),
150150
service: 'bigtable.admin'
151151
},
152152
BigtableInstanceAdmin: {
153-
baseUrl: 'bigtableadmin.googleapis.com',
153+
baseUrl: 'bigtableadmin.googleapis.com.',
154154
path: googleProtoFiles(
155155
'bigtable/admin/v2/bigtable_instance_admin.proto'
156156
),
157157
service: 'bigtable.admin'
158158
},
159159
Operations: {
160-
baseUrl: 'bigtableadmin.googleapis.com',
160+
baseUrl: 'bigtableadmin.googleapis.com.',
161161
path: googleProtoFiles('longrunning/operations.proto'),
162162
service: 'longrunning',
163163
apiVersion: 'v1'
164164
}
165165
});
166166

167167
assert.deepEqual(calledWith.scopes, [
168-
'https://www.googleapis.com/auth/bigtable.admin',
169-
'https://www.googleapis.com/auth/bigtable.data',
170-
'https://www.googleapis.com/auth/cloud-platform'
168+
'https://www.googleapis.com./auth/bigtable.admin',
169+
'https://www.googleapis.com./auth/bigtable.data',
170+
'https://www.googleapis.com./auth/cloud-platform'
171171
]);
172172

173173
assert.deepEqual(calledWith.packageJson, require('../package.json'));

‎packages/common-grpc/test/service.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ describe('GrpcService', function() {
390390
});
391391

392392
it('should store the baseUrl properly', function() {
393-
var fakeBaseUrl = 'a.googleapis.com';
393+
var fakeBaseUrl = 'a.googleapis.com.';
394394

395395
grpcLoadOverride = function() {
396396
return MOCK_GRPC_API;
@@ -1914,7 +1914,7 @@ describe('GrpcService', function() {
19141914
});
19151915

19161916
it('should use the baseUrl override if applicable', function() {
1917-
var fakeBaseUrl = 'a.googleapis.com';
1917+
var fakeBaseUrl = 'a.googleapis.com.';
19181918
var fakeService = {};
19191919

19201920
grpcService.protos = {

‎packages/compute/src/index.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ function Compute(options) {
9595
}
9696

9797
var config = {
98-
baseUrl: 'https://www.googleapis.com/compute/v1',
99-
scopes: ['https://www.googleapis.com/auth/compute'],
98+
baseUrl: 'https://www.googleapis.com./compute/v1',
99+
scopes: ['https://www.googleapis.com./auth/compute'],
100100
packageJson: require('../package.json')
101101
};
102102

‎packages/compute/src/service.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Service.prototype.delete = function(callback) {
263263
Service.prototype.getHealth = function(group, callback) {
264264
if (!is.string(group)) {
265265
group = format('{baseUrl}/projects/{p}/zones/{z}/instanceGroups/{n}', {
266-
baseUrl: 'https://www.googleapis.com/compute/v1',
266+
baseUrl: 'https://www.googleapis.com./compute/v1',
267267
p: this.parent.projectId,
268268
z: group.zone.name || group.zone,
269269
n: group.name

0 commit comments

Comments
 (0)