Use arrow functions (#188)

Author: JustinBeckwith

handwritten/bigquery/benchmark/bench.ts

@@ -30,7 +30,7 @@ const queryJson = fs.readFileSync(process.argv[2]);
 const queries = JSON.parse(queryJson);
 const client = new BigQuery(env);
 
-const doQuery = function(queryTxt, callback) {
+const doQuery = (queryTxt, callback) =>{
   const startMilli = new Date().getTime();
   let numRows = 0;
   let numCols;
@@ -61,9 +61,8 @@ const doQuery = function(queryTxt, callback) {
       }
       numRows++;
     })
-    .on('end', function() {
+    .on('end', () => {
       const timeTotalMilli = new Date().getTime() - startMilli;
-
       console.log(
         `query ${queryTxt}:`,
           `got ${numRows} rows,`,

handwritten/bigquery/samples/quickstart.js

@@ -35,7 +35,6 @@ bigquery
   .createDataset(datasetName)
   .then(results => {
     const dataset = results[0];
-
     console.log(`Dataset ${dataset.id} created.`);
   })
   .catch(err => {

handwritten/bigquery/src/dataset.ts

@@ -204,8 +204,8 @@ class Dataset extends ServiceObject {
     super({
       parent: bigQuery,
       baseUrl: '/datasets',
-      id: id,
-      methods: methods,
+      id,
+      methods,
       requestModule: request,
       createMethod: (id, options, callback) => {
         if (is.fn(options)) {
@@ -226,12 +226,11 @@ class Dataset extends ServiceObject {
     // Catch all for read-modify-write cycle
     // https://cloud.google.com/bigquery/docs/api-performance#read-patch-write
     this.interceptors.push({
-      request: function(reqOpts) {
+      request: reqOpts => {
         if (reqOpts.method === 'PATCH' && reqOpts.json.etag) {
           reqOpts.headers = reqOpts.headers || {};
           reqOpts.headers['If-Match'] = reqOpts.json.etag;
         }
-
         return reqOpts;
       },
     });
@@ -295,7 +294,7 @@ class Dataset extends ServiceObject {
     });
 
     return this.bigQuery.createQueryJob(options, callback);
-  };
+  }
 
   /**
    * Run a query scoped to your dataset as a readable object stream.
@@ -322,7 +321,7 @@ class Dataset extends ServiceObject {
     });
 
     return this.bigQuery.createQueryStream(options);
-  };
+  }
 
   /**
    * Create a table given a tableId or configuration object.
@@ -400,7 +399,7 @@ class Dataset extends ServiceObject {
         callback(null, table, resp);
       }
     );
-  };
+  }
 
   /**
    * Delete the dataset.
@@ -454,7 +453,7 @@ class Dataset extends ServiceObject {
       },
       callback
     );
-  };
+  }
 
   /**
    * Get a list of tables.
@@ -540,7 +539,7 @@ class Dataset extends ServiceObject {
         callback(null, tables, nextQuery, resp);
       }
     );
-  };
+  }
 
   /**
    * Run a query scoped to your dataset.
@@ -566,7 +565,7 @@ class Dataset extends ServiceObject {
     });
 
     return this.bigQuery.query(options, callback);
-  };
+  }
 
   /**
    * Create a Table object.
@@ -597,7 +596,7 @@ class Dataset extends ServiceObject {
     );
 
     return new Table(this, id, options);
-  };
+  }
 }
 
 /*! Developer Documentation

handwritten/bigquery/src/index.ts

@@ -579,7 +579,7 @@ util.inherits(BigQuery, common.Service);
   if (typeName === 'ARRAY') {
     queryParameter.parameterValue.arrayValues = value.map(function(value) {
       return {
-        value: value,
+        value,
       };
     });
   } else if (typeName === 'STRUCT') {
@@ -795,7 +795,7 @@ BigQuery.prototype.createQueryJob = function(options, callback) {
 
   const reqOpts = {
     configuration: {
-      query: query,
+      query,
     } as any,
   } as any;
 
@@ -931,7 +931,7 @@ BigQuery.prototype.createJob = function(options, callback) {
 
   reqOpts.jobReference = {
     projectId: this.projectId,
-    jobId: jobId,
+    jobId,
     location: this.location,
   };
 

handwritten/bigquery/src/job.ts

@@ -223,8 +223,8 @@ class Job extends Operation {
     super({
       parent: bigQuery,
       baseUrl: '/jobs',
-      id: id,
-      methods: methods,
+      id,
+      methods,
       requestModule: request,
     } as any);
 
@@ -306,7 +306,7 @@ class Job extends Operation {
       },
       callback
     );
-  };
+  }
 
   /**
    * @callback QueryResultsCallback
@@ -434,7 +434,7 @@ class Job extends Operation {
         callback(null, rows, nextQuery, resp);
       }
     );
-  };
+  }
 
   /**
    * This method will be called by `getQueryResultsStream()`. It is required to
@@ -445,7 +445,7 @@ class Job extends Operation {
   getQueryResultsAsStream_(options, callback) {
     options = extend({autoPaginate: false}, options);
     this.getQueryResults(options, callback);
-  };
+  }
 
   /**
    * Poll for a status update. Execute the callback:
@@ -476,7 +476,7 @@ class Job extends Operation {
 
       callback(null, metadata);
     });
-  };
+  }
 }
 
 /*! Developer Documentation