Skip to content

Commit 41297f9

Browse files
authored
Simplify Translate samples and bring up to standard. (#228)
1 parent 37b2755 commit 41297f9

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

handwritten/bigquery/samples/system-test/quickstart.test.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,29 @@
1717

1818
const proxyquire = require(`proxyquire`).noPreserveCache();
1919
const bigquery = proxyquire(`@google-cloud/bigquery`, {})();
20+
var uuid = require('node-uuid');
2021

21-
const datasetName = `my_new_dataset`;
22+
const expectedDatasetId = `my_new_dataset`;
23+
let datasetId = `nodejs-docs-samples-test-${uuid.v4()}`;
24+
datasetId = datasetId.replace(/-/gi, `_`);
2225

23-
describe(`bigquery:quickstart`, () => {
26+
describe.only(`bigquery:quickstart`, () => {
2427
let bigqueryMock, BigqueryMock;
2528

2629
after((done) => {
27-
bigquery.dataset(datasetName).delete(() => {
30+
bigquery.dataset(datasetId).delete(() => {
2831
// Ignore any error, the dataset might not have been created
2932
done();
3033
});
3134
});
3235

3336
it(`should create a dataset`, (done) => {
3437
bigqueryMock = {
35-
createDataset: (_datasetName, _callback) => {
36-
assert.equal(_datasetName, datasetName);
38+
createDataset: (_datasetId, _callback) => {
39+
assert.equal(_datasetId, expectedDatasetId);
3740
assert.equal(typeof _callback, 'function');
3841

39-
bigquery.createDataset(datasetName, (err, dataset, apiResponse) => {
42+
bigquery.createDataset(datasetId, (err, dataset, apiResponse) => {
4043
_callback(err, dataset, apiResponse);
4144
assert.ifError(err);
4245
assert.notEqual(dataset, undefined);

0 commit comments

Comments
 (0)