more system tests

Author: stephenplusplus

lib/compute/vm.js

@@ -156,22 +156,30 @@ VM.prototype.delete = function(callback) {
  *
  * @resource [Instance: detachDisk API Documentation]{@link https://cloud.google.com/compute/docs/reference/v1/instances/detachDisk}
  *
- * @param {string} deviceName - The name of the device to detach.
+ * @throws {Error} if a {module:compute/disk} is not provided.
+ *
+ * @param {module:compute/disk} disk - The disk to detach.
  * @param {function} callback - The callback function.
  * @param {?error} callback.err - An error returned while making this request.
  * @param {module:compute/operation} callback.operation - An operation object
  *     that can be used to check the status of the request.
  * @param {object} callback.apiResponse - The full API response.
  *
  * @example
- * vm.detachDisk('my-device', function(err, operation, apiResponse) {
+ * var disk = zone.disk('my-disk');
+ *
+ * vm.detachDisk(disk, function(err, operation, apiResponse) {
  *   // `operation` is an Operation object that can be used to check the status
  *   // of the request.
  * });
  */
-VM.prototype.detachDisk = function(deviceName, callback) {
+VM.prototype.detachDisk = function(disk, callback) {
+  if (!(disk instanceof Disk)) {
+    throw new Error('A Disk object must be provided.');
+  }
+
   var query = {
-    deviceName: deviceName
+    deviceName: disk.name
   };
 
   this.makeReq_('POST', '/detachDisk', query, null, callback);
@@ -239,7 +247,7 @@ VM.prototype.getSerialPortOutput = function(port, callback) {
       return;
     }
 
-    callback(null, resp.content, resp);
+    callback(null, resp.contents, resp);
   });
 };
 

system-test/compute.js

@@ -454,6 +454,63 @@ describe('Compute', function() {
     it('should access a VM through a Zone', function(done) {
       zone.vm(VM_NAME).getMetadata(done);
     });
+
+    it('should attach and detach a disk', function(done) {
+      compute.getDisks()
+        .on('error', done)
+        .once('data', function(disk) {
+          this.end();
+
+          vm.attachDisk(disk, function(err) {
+            assert.ifError(err);
+
+            vm.detachDisk(disk, function(err, operation) {
+              assert.ifError(err);
+              operation.onComplete(done);
+            });
+          });
+        });
+    });
+
+    it('should get serial port output', function(done) {
+      vm.getSerialPortOutput(done);
+    });
+
+    it('should set tags', function(done) {
+      var newTagName = 'new-tag';
+
+      vm.getTags(function(err, tags, fingerprint) {
+        assert.ifError(err);
+
+        tags.push(newTagName);
+
+        vm.setTags(tags, fingerprint, function(err, operation) {
+          assert.ifError(err);
+
+          operation.onComplete(function(err) {
+            assert.ifError(err);
+
+            vm.getTags(function(err, tags) {
+              assert.ifError(err);
+              assert(tags.indexOf(newTagName) > -1);
+              done();
+            });
+          });
+        });
+      });
+    });
+
+    it('should reset', function(done) {
+      vm.reset(done);
+    });
+
+    it('should start', function(done) {
+      vm.start(done);
+    });
+
+    it('should stop', function(done) {
+      vm.stop(done);
+    });
   });
 
   describe('zones', function() {