updated FQDN's to googleapis.com with a trailing dot (#2214)

ericuldall · callmehiphop · commit 13d4ed52402b · 2017-04-14T12:19:55.000-04:00
diff --git a/packages/bigquery/src/index.js b/packages/bigquery/src/index.js
@@ -66,7 +66,7 @@ function BigQuery(options) {
   }
 
   var config = {
-    baseUrl: 'https://www.googleapis.com/bigquery/v2',
+    baseUrl: 'https://www.googleapis.com./bigquery/v2',
     scopes: ['https://www.googleapis.com/auth/bigquery'],
     packageJson: require('../package.json')
   };
diff --git a/packages/bigquery/src/table.js b/packages/bigquery/src/table.js
@@ -548,7 +548,7 @@ Table.prototype.createWriteStream = function(metadata) {
       },
       request: {
         uri: format('{base}/{projectId}/jobs', {
-          base: 'https://www.googleapis.com/upload/bigquery/v2/projects',
+          base: 'https://www.googleapis.com./upload/bigquery/v2/projects',
           projectId: self.bigQuery.projectId
         })
       }
diff --git a/packages/bigquery/test/index.js b/packages/bigquery/test/index.js
@@ -144,7 +144,7 @@ describe('BigQuery', function() {
 
       var calledWith = bq.calledWith_[0];
 
-      var baseUrl = 'https://www.googleapis.com/bigquery/v2';
+      var baseUrl = 'https://www.googleapis.com./bigquery/v2';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.deepEqual(calledWith.scopes, [
         'https://www.googleapis.com/auth/bigquery'
diff --git a/packages/bigquery/test/table.js b/packages/bigquery/test/table.js
@@ -665,7 +665,7 @@ describe('BigQuery/Table', function() {
 
       it('should pass the correct request uri', function(done) {
         makeWritableStreamOverride = function(stream, options) {
-          var uri = 'https://www.googleapis.com/upload/bigquery/v2/projects/' +
+          var uri = 'https://www.googleapis.com./upload/bigquery/v2/projects/' +
             table.bigQuery.projectId + '/jobs';
           assert.equal(options.request.uri, uri);
           done();
diff --git a/packages/bigtable/src/index.js b/packages/bigtable/src/index.js
@@ -309,8 +309,8 @@ function Bigtable(options) {
     return new Bigtable(options);
   }
 
-  var baseUrl = 'bigtable.googleapis.com';
-  var adminBaseUrl = 'bigtableadmin.googleapis.com';
+  var baseUrl = 'bigtable.googleapis.com.';
+  var adminBaseUrl = 'bigtableadmin.googleapis.com.';
 
   var customEndpoint = options.apiEndpoint ||
     process.env.BIGTABLE_EMULATOR_HOST;
diff --git a/packages/bigtable/test/index.js b/packages/bigtable/test/index.js
@@ -136,28 +136,28 @@ describe('Bigtable', function() {
 
       var calledWith = bigtable.calledWith_[0];
 
-      assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com');
+      assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com.');
       assert.strictEqual(calledWith.service, 'bigtable');
       assert.strictEqual(calledWith.apiVersion, 'v2');
       assert.strictEqual(calledWith.customEndpoint, false);
 
       assert.deepEqual(calledWith.protoServices, {
         Bigtable: googleProtoFiles('bigtable/v2/bigtable.proto'),
         BigtableTableAdmin: {
-          baseUrl: 'bigtableadmin.googleapis.com',
+          baseUrl: 'bigtableadmin.googleapis.com.',
           path: googleProtoFiles(
             'bigtable/admin/v2/bigtable_table_admin.proto'),
           service: 'bigtable.admin'
         },
         BigtableInstanceAdmin: {
-          baseUrl: 'bigtableadmin.googleapis.com',
+          baseUrl: 'bigtableadmin.googleapis.com.',
           path: googleProtoFiles(
             'bigtable/admin/v2/bigtable_instance_admin.proto'
           ),
           service: 'bigtable.admin'
         },
         Operations: {
-          baseUrl: 'bigtableadmin.googleapis.com',
+          baseUrl: 'bigtableadmin.googleapis.com.',
           path: googleProtoFiles('longrunning/operations.proto'),
           service: 'longrunning',
           apiVersion: 'v1'
diff --git a/packages/common-grpc/test/service.js b/packages/common-grpc/test/service.js
@@ -390,7 +390,7 @@ describe('GrpcService', function() {
     });
 
     it('should store the baseUrl properly', function() {
-      var fakeBaseUrl = 'a.googleapis.com';
+      var fakeBaseUrl = 'a.googleapis.com.';
 
       grpcLoadOverride = function() {
         return MOCK_GRPC_API;
@@ -1914,7 +1914,7 @@ describe('GrpcService', function() {
     });
 
     it('should use the baseUrl override if applicable', function() {
-      var fakeBaseUrl = 'a.googleapis.com';
+      var fakeBaseUrl = 'a.googleapis.com.';
       var fakeService = {};
 
       grpcService.protos = {
diff --git a/packages/compute/src/index.js b/packages/compute/src/index.js
@@ -95,7 +95,7 @@ function Compute(options) {
   }
 
   var config = {
-    baseUrl: 'https://www.googleapis.com/compute/v1',
+    baseUrl: 'https://www.googleapis.com./compute/v1',
     scopes: ['https://www.googleapis.com/auth/compute'],
     packageJson: require('../package.json')
   };
diff --git a/packages/compute/src/service.js b/packages/compute/src/service.js
@@ -263,7 +263,7 @@ Service.prototype.delete = function(callback) {
 Service.prototype.getHealth = function(group, callback) {
   if (!is.string(group)) {
     group = format('{baseUrl}/projects/{p}/zones/{z}/instanceGroups/{n}', {
-      baseUrl: 'https://www.googleapis.com/compute/v1',
+      baseUrl: 'https://www.googleapis.com./compute/v1',
       p: this.parent.projectId,
       z: group.zone.name || group.zone,
       n: group.name
diff --git a/packages/compute/src/vm.js b/packages/compute/src/vm.js
@@ -104,7 +104,7 @@ function VM(zone, name) {
   this.waiters = [];
 
   this.url = format('{base}/{project}/zones/{zone}/instances/{name}', {
-    base: 'https://www.googleapis.com/compute/v1/projects',
+    base: 'https://www.googleapis.com./compute/v1/projects',
     project: zone.compute.projectId,
     zone: zone.name,
     name: this.name
diff --git a/packages/compute/src/zone.js b/packages/compute/src/zone.js
@@ -257,7 +257,7 @@ Zone.prototype.createAutoscaler = function(name, config, callback) {
 
   if (!/^https*:/.test(json.target)) {
     json.target = [
-      'https://content.googleapis.com/compute/v1/projects/',
+      'https://content.googleapis.com./compute/v1/projects/',
       this.compute.projectId,
       '/zones/',
       this.name,
@@ -554,7 +554,7 @@ Zone.prototype.createInstanceGroup = function(name, options, callback) {
  *       boot: true,
  *       initializeParams: {
  *         sourceImage:
- *           'https://www.googleapis.com/compute/v1/projects' +
+ *           'https://www.googleapis.com./compute/v1/projects' +
  *           '/debian-cloud/global/images/debian-7-wheezy-v20150710'
  *       }
  *     }
diff --git a/packages/compute/test/index.js b/packages/compute/test/index.js
@@ -205,7 +205,7 @@ describe('Compute', function() {
 
       var calledWith = compute.calledWith_[0];
 
-      var baseUrl = 'https://www.googleapis.com/compute/v1';
+      var baseUrl = 'https://www.googleapis.com./compute/v1';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.deepEqual(calledWith.scopes, [
         'https://www.googleapis.com/auth/compute'
diff --git a/packages/compute/test/service.js b/packages/compute/test/service.js
@@ -205,7 +205,7 @@ describe('Service', function() {
         service.request = function(reqOpts) {
           assert.deepEqual(reqOpts.json, {
             group: [
-              'https://www.googleapis.com/compute/v1/projects/',
+              'https://www.googleapis.com./compute/v1/projects/',
               COMPUTE.projectId,
               '/zones/',
               group.zone,
@@ -232,7 +232,7 @@ describe('Service', function() {
         service.request = function(reqOpts) {
           assert.deepEqual(reqOpts.json, {
             group: [
-              'https://www.googleapis.com/compute/v1/projects/',
+              'https://www.googleapis.com./compute/v1/projects/',
               COMPUTE.projectId,
               '/zones/',
               group.zone.name,
diff --git a/packages/compute/test/vm.js b/packages/compute/test/vm.js
@@ -110,7 +110,7 @@ describe('VM', function() {
 
     it('should localize the URL of the VM', function() {
       assert.strictEqual(vm.url, [
-        'https://www.googleapis.com/compute/v1/projects',
+        'https://www.googleapis.com./compute/v1/projects',
         COMPUTE.projectId,
         'zones',
         ZONE.name,
diff --git a/packages/compute/test/zone.js b/packages/compute/test/zone.js
@@ -286,7 +286,7 @@ describe('Zone', function() {
 
         zone.request = function(reqOpts) {
           var expectedTarget = [
-            'https://content.googleapis.com/compute/v1/projects/',
+            'https://content.googleapis.com./compute/v1/projects/',
             COMPUTE.projectId,
             '/zones/',
             zone.name,
diff --git a/packages/datastore/src/index.js b/packages/datastore/src/index.js
@@ -300,7 +300,7 @@ function Datastore(options) {
     return new Datastore(options);
   }
 
-  this.defaultBaseUrl_ = 'datastore.googleapis.com';
+  this.defaultBaseUrl_ = 'datastore.googleapis.com.';
   this.determineBaseUrl_(options.apiEndpoint);
 
   this.namespace = options.namespace;
diff --git a/packages/datastore/src/v1/datastore_client.js b/packages/datastore/src/v1/datastore_client.js
@@ -500,4 +500,4 @@ function DatastoreClientBuilder(gaxGrpc) {
 }
 module.exports = DatastoreClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/datastore/test/index.js b/packages/datastore/test/index.js
@@ -116,7 +116,10 @@ describe('Datastore', function() {
     });
 
     it('should set the default base URL', function() {
-      assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com');
+      assert.strictEqual(
+        datastore.defaultBaseUrl_,
+        'datastore.googleapis.com.'
+      );
     });
 
     it('should set default API connection details', function(done) {
diff --git a/packages/dns/src/index.js b/packages/dns/src/index.js
@@ -53,7 +53,7 @@ function DNS(options) {
   }
 
   var config = {
-    baseUrl: 'https://www.googleapis.com/dns/v1',
+    baseUrl: 'https://www.googleapis.com./dns/v1',
     scopes: [
       'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
       'https://www.googleapis.com/auth/cloud-platform'
diff --git a/packages/dns/test/index.js b/packages/dns/test/index.js
@@ -125,7 +125,7 @@ describe('DNS', function() {
 
       var calledWith = dns.calledWith_[0];
 
-      var baseUrl = 'https://www.googleapis.com/dns/v1';
+      var baseUrl = 'https://www.googleapis.com./dns/v1';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.deepEqual(calledWith.scopes, [
         'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
diff --git a/packages/error-reporting/src/google-apis/auth-client.js b/packages/error-reporting/src/google-apis/auth-client.js
@@ -27,7 +27,7 @@ var isString = is.string;
 var SCOPES = ['https://www.googleapis.com/auth/cloud-platform'];
 
 /* @const {String} Base Error Reporting API */
-var API = 'https://clouderrorreporting.googleapis.com/v1beta1/projects';
+var API = 'https://clouderrorreporting.googleapis.com./v1beta1/projects';
 
 /**
  * The RequestHandler constructor initializes several properties on the
@@ -90,7 +90,7 @@ class RequestHandler extends common.Service {
     var pid = config.getProjectId();
     super({
       packageJson: pkg,
-      baseUrl: 'https://clouderrorreporting.googleapis.com/v1beta1/',
+      baseUrl: 'https://clouderrorreporting.googleapis.com./v1beta1/',
       scopes: SCOPES,
       projectId: pid !== null ? pid : undefined,
       projectIdRequired: true
diff --git a/packages/error-reporting/system-test/testAuthClient.js b/packages/error-reporting/system-test/testAuthClient.js
@@ -114,8 +114,8 @@ const TEST_RUNNER = (function() {
     beforeEach(function() {
       env.setProjectId().setKeyFilename().setProduction();
       fakeService = nock(
-        'https://clouderrorreporting.googleapis.com/v1beta1/projects/' +
-        env.projectId
+        'https://clouderrorreporting.googleapis.com./v1beta1/projects/' +
+        process.env.GCLOUD_PROJECT
      ).persist().post('/events:report');
       logger = createLogger({logLevel: 5});
       client = new RequestHandler(
diff --git a/packages/language/src/v1/language_service_client.js b/packages/language/src/v1/language_service_client.js
@@ -31,7 +31,7 @@ var configData = require('./language_service_client_config');
 var extend = require('extend');
 var gax = require('google-gax');
 
-var SERVICE_ADDRESS = 'language.googleapis.com';
+var SERVICE_ADDRESS = 'language.googleapis.com.';
 
 var DEFAULT_SERVICE_PORT = 443;
 
@@ -369,4 +369,4 @@ function LanguageServiceClientBuilder(gaxGrpc) {
 }
 module.exports = LanguageServiceClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/language/src/v1beta2/language_service_client.js b/packages/language/src/v1beta2/language_service_client.js
@@ -31,7 +31,7 @@ var configData = require('./language_service_client_config');
 var extend = require('extend');
 var gax = require('google-gax');
 
-var SERVICE_ADDRESS = 'language.googleapis.com';
+var SERVICE_ADDRESS = 'language.googleapis.com.';
 
 var DEFAULT_SERVICE_PORT = 443;
 
@@ -426,4 +426,4 @@ function LanguageServiceClientBuilder(gaxGrpc) {
 }
 module.exports = LanguageServiceClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/logging/src/log.js b/packages/logging/src/log.js
@@ -545,7 +545,7 @@ Log.prototype.warning = function(entry, options, callback) {
  * //-
  * // You may also pass multiple log entries to write.
  * //-
- * var secondEntry = log.entry('compute.googleapis.com', {
+ * var secondEntry = log.entry('gce_instance', {
  *   user: 'my_username'
  * });
  *
diff --git a/packages/logging/src/v2/config_service_v2_client.js b/packages/logging/src/v2/config_service_v2_client.js
@@ -602,4 +602,4 @@ function ConfigServiceV2ClientBuilder(gaxGrpc) {
 }
 module.exports = ConfigServiceV2ClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/logging/src/v2/logging_service_v2_client.js b/packages/logging/src/v2/logging_service_v2_client.js
@@ -229,7 +229,7 @@ LoggingServiceV2Client.prototype.getProjectId = function(callback) {
  *
  *   `[LOG_ID]` must be URL-encoded. For example,
  *   `"projects/my-project-id/logs/syslog"`,
- *   `"organizations/1234567890/logs/cloudresourcemanager.googleapis.com%2Factivity"`.
+ *   `"organizations/1234567890/logs/cloudresourcemanager.googleapis.com.%2Factivity"`.
  *   For more information about log names, see
  *   {@link LogEntry}.
  * @param {Object=} options
@@ -287,7 +287,7 @@ LoggingServiceV2Client.prototype.deleteLog = function(request, options, callback
  *
  *   `[LOG_ID]` must be URL-encoded. For example,
  *   `"projects/my-project-id/logs/syslog"` or
- *   `"organizations/1234567890/logs/cloudresourcemanager.googleapis.com%2Factivity"`.
+ *   `"organizations/1234567890/logs/cloudresourcemanager.googleapis.com.%2Factivity"`.
  *   For more information about log names, see
  *   {@link LogEntry}.
  * @param {Object=} request.resource
@@ -835,4 +835,4 @@ function LoggingServiceV2ClientBuilder(gaxGrpc) {
 }
 module.exports = LoggingServiceV2ClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/logging/src/v2/metrics_service_v2_client.js b/packages/logging/src/v2/metrics_service_v2_client.js
@@ -555,4 +555,4 @@ function MetricsServiceV2ClientBuilder(gaxGrpc) {
 }
 module.exports = MetricsServiceV2ClientBuilder;
 module.exports.SERVICE_ADDRESS = SERVICE_ADDRESS;
-module.exports.ALL_SCOPES = ALL_SCOPES;
+module.exports.ALL_SCOPES = ALL_SCOPES;
diff --git a/packages/prediction/src/index.js b/packages/prediction/src/index.js
@@ -63,7 +63,7 @@ function Prediction(options) {
   }
 
   var config = {
-    baseUrl: 'https://www.googleapis.com/prediction/v1.6',
+    baseUrl: 'https://www.googleapis.com./prediction/v1.6',
     scopes: [
       'https://www.googleapis.com/auth/prediction',
       'https://www.googleapis.com/auth/devstorage.read_only'
diff --git a/packages/prediction/test/index.js b/packages/prediction/test/index.js
@@ -125,7 +125,7 @@ describe('Prediction', function() {
 
       var calledWith = prediction.calledWith_[0];
 
-      var baseUrl = 'https://www.googleapis.com/prediction/v1.6';
+      var baseUrl = 'https://www.googleapis.com./prediction/v1.6';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.deepEqual(calledWith.scopes, [
         'https://www.googleapis.com/auth/prediction',
diff --git a/packages/pubsub/src/index.js b/packages/pubsub/src/index.js
@@ -66,7 +66,7 @@ function PubSub(options) {
     return new PubSub(options);
   }
 
-  this.defaultBaseUrl_ = 'pubsub.googleapis.com';
+  this.defaultBaseUrl_ = 'pubsub.googleapis.com.';
   this.determineBaseUrl_();
 
   var config = {
diff --git a/packages/pubsub/test/index.js b/packages/pubsub/test/index.js
@@ -149,7 +149,7 @@ describe('PubSub', function() {
 
       var calledWith = pubsub.calledWith_[0];
 
-      var baseUrl = 'pubsub.googleapis.com';
+      var baseUrl = 'pubsub.googleapis.com.';
       assert.strictEqual(calledWith.baseUrl, baseUrl);
       assert.strictEqual(calledWith.service, 'pubsub');
       assert.strictEqual(calledWith.apiVersion, 'v1');
@@ -161,7 +161,7 @@ describe('PubSub', function() {
     });
 
     it('should set the defaultBaseUrl_', function() {
-      assert.strictEqual(pubsub.defaultBaseUrl_, 'pubsub.googleapis.com');
+      assert.strictEqual(pubsub.defaultBaseUrl_, 'pubsub.googleapis.com.');
     });
 
     it('should use the PUBSUB_EMULATOR_HOST env var', function() {
diff --git a/packages/resource/src/index.js b/packages/resource/src/index.js
@@ -58,7 +58,7 @@ function Resource(options) {
   }
 
   var config = {
-    baseUrl: 'https://cloudresourcemanager.googleapis.com/v1',
+    baseUrl: 'https://cloudresourcemanager.googleapis.com./v1',
     scopes: ['https://www.googleapis.com/auth/cloud-platform'],
     projectIdRequired: false,
     packageJson: require('../package.json')
diff --git a/packages/resource/test/index.js b/packages/resource/test/index.js
diff --git a/packages/spanner/src/index.js b/packages/spanner/src/index.js
diff --git a/packages/spanner/test/index.js b/packages/spanner/test/index.js
diff --git a/packages/speech/src/index.js b/packages/speech/src/index.js
diff --git a/packages/speech/system-test/speech.js b/packages/speech/system-test/speech.js
diff --git a/packages/speech/test/index.js b/packages/speech/test/index.js
diff --git a/packages/storage/src/file.js b/packages/storage/src/file.js
diff --git a/packages/storage/src/index.js b/packages/storage/src/index.js
diff --git a/packages/storage/test/file.js b/packages/storage/test/file.js
diff --git a/packages/storage/test/index.js b/packages/storage/test/index.js
diff --git a/packages/translate/src/index.js b/packages/translate/src/index.js
diff --git a/packages/translate/test/index.js b/packages/translate/test/index.js

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ function BigQuery(options) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`var config = {`
`69`		`- baseUrl: 'https://www.googleapis.com/bigquery/v2',`
	`69`	`+ baseUrl: 'https://www.googleapis.com./bigquery/v2',`
`70`	`70`	`scopes: ['https://www.googleapis.com/auth/bigquery'],`
`71`	`71`	`packageJson: require('../package.json')`
`72`	`72`	`};`
Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ Table.prototype.createWriteStream = function(metadata) {`
`548`	`548`	`},`
`549`	`549`	`request: {`
`550`	`550`	`uri: format('{base}/{projectId}/jobs', {`
`551`		`- base: 'https://www.googleapis.com/upload/bigquery/v2/projects',`
	`551`	`+ base: 'https://www.googleapis.com./upload/bigquery/v2/projects',`
`552`	`552`	`projectId: self.bigQuery.projectId`
`553`	`553`	`})`
`554`	`554`	`}`
Original file line number	Diff line number	Diff line change
`@@ -309,8 +309,8 @@ function Bigtable(options) {`
`309`	`309`	`return new Bigtable(options);`
`310`	`310`	`}`
`311`	`311`
`312`		`- var baseUrl = 'bigtable.googleapis.com';`
`313`		`- var adminBaseUrl = 'bigtableadmin.googleapis.com';`
	`312`	`+ var baseUrl = 'bigtable.googleapis.com.';`
	`313`	`+ var adminBaseUrl = 'bigtableadmin.googleapis.com.';`
`314`	`314`
`315`	`315`	`var customEndpoint = options.apiEndpoint \|\|`
`316`	`316`	`process.env.BIGTABLE_EMULATOR_HOST;`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ function Compute(options) {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`var config = {`
`98`		`- baseUrl: 'https://www.googleapis.com/compute/v1',`
	`98`	`+ baseUrl: 'https://www.googleapis.com./compute/v1',`
`99`	`99`	`scopes: ['https://www.googleapis.com/auth/compute'],`
`100`	`100`	`packageJson: require('../package.json')`
`101`	`101`	`};`