Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 075f9e8

Browse files
authored
fix: rename local var page in generated tests (#577)
1 parent f0400cf commit 075f9e8

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,8 +522,8 @@ def test_{{ method.name|snake_case }}_pages():
522522
RuntimeError,
523523
)
524524
pages = list(client.{{ method.name|snake_case }}(request={}).pages)
525-
for page, token in zip(pages, ['abc','def','ghi', '']):
526-
assert page.raw_page.next_page_token == token
525+
for page_, token in zip(pages, ['abc','def','ghi', '']):
526+
assert page_.raw_page.next_page_token == token
527527
{% elif method.lro and "next_page_token" in method.lro.response_type.fields.keys() %}
528528
def test_{{ method.name|snake_case }}_raw_page_lro():
529529
response = {{ method.lro.response_type.ident }}()

gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -838,8 +838,8 @@ def test_{{ method.name|snake_case }}_pages():
838838
RuntimeError,
839839
)
840840
pages = list(client.{{ method.name|snake_case }}(request={}).pages)
841-
for page, token in zip(pages, ['abc','def','ghi', '']):
842-
assert page.raw_page.next_page_token == token
841+
for page_, token in zip(pages, ['abc','def','ghi', '']):
842+
assert page_.raw_page.next_page_token == token
843843

844844
@pytest.mark.asyncio
845845
async def test_{{ method.name|snake_case }}_async_pager():
@@ -928,10 +928,10 @@ async def test_{{ method.name|snake_case }}_async_pages():
928928
RuntimeError,
929929
)
930930
pages = []
931-
async for page in (await client.{{ method.name|snake_case }}(request={})).pages:
932-
pages.append(page)
933-
for page, token in zip(pages, ['abc','def','ghi', '']):
934-
assert page.raw_page.next_page_token == token
931+
async for page_ in (await client.{{ method.name|snake_case }}(request={})).pages:
932+
pages.append(page_)
933+
for page_, token in zip(pages, ['abc','def','ghi', '']):
934+
assert page_.raw_page.next_page_token == token
935935
{% elif method.lro and "next_page_token" in method.lro.response_type.fields.keys() %}
936936
def test_{{ method.name|snake_case }}_raw_page_lro():
937937
response = {{ method.lro.response_type.ident }}()

0 commit comments

Comments
 (0)