Repository navigation
fix(blueprints): apply Workbench notebook owners - #338
Merged
aghassemlouei merged 1 commit intoOct 22, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aghassemlouei
force-pushed
the
fix/317-workbench-instance-owner
branch
from
October 22, 2026 14:54
5937f39 to
c0ffa77
Compare
aghassemlouei
requested review from
Calvin-Cheng1,
LanceWray and
mgcarey-google
October 22, 2026 14:56
aghassemlouei
force-pushed
the
fix/317-workbench-instance-owner
branch
from
October 22, 2026 15:09
c0ffa77 to
5937f39
Compare
aghassemlouei
approved these changes
Oct 22, 2026
aghassemlouei
left a comment
Member
There was a problem hiding this comment.
Thanks for catching and fixing the Workbench owner list conversion in vertex-mlops, @huong8373tt-beep! Validated the plan output and this looks good to merge.
Merged
18 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #317.
var.notebooks[each.key].owneris astring, whereasgoogle_workbench_instance.playgroundexpectsinstance_ownersto be alist(string). Callingtry(tolist(var.notebooks[each.key].owner), null)inblueprints/fedramp-high/vertex-mlops/vertex.tffailed type conversion on strings and always evaluated tonull. This change passesnullwhenowneris unset and[var.notebooks[each.key].owner]when configured, and documents the optionalownersetting forUSER_MANAGEDnotebooks inREADME.mdandterraform.tfvars.sample.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/stages-aw/can be leveraged for this change.docs/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
bash tools/run_tests.shandbash tools/lint.sh.terraform initandterraform planinblueprints/fedramp-high/vertex-mlopsthatgoogle_workbench_instance.playgroundresolvesinstance_ownersto[<owner>]whenowneris set andnullwhen omitted.