Skip to content

refactor(tests): flatten test suite into tests/ and expand unit coverage - #299

Merged
Calvin-Cheng1 merged 1 commit into
mainfrom
refactor/flatten-tests-directory
Oct 23, 2026
Merged

Calvin-Cheng1 merged 1 commit into
mainfrom
refactor/flatten-tests-directory

Conversation

@aghassemlouei

@aghassemlouei aghassemlouei commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Description

  • Flatten tests/gem4gov_cli/, tests/tools/, and tests/scripts/ directly into tests/ while preserving Git rename history across all 17 relocated test files (including tests/test_lint_sh.py), and remove redundant tests/conftest.py, tests/gem4gov_cli/__init__.py, tests/tools/__init__.py, and tests/scripts/run_shell_tests.sh wrappers.
  • Expand single-scenario unit tests with concrete argument and output assertions across test_auth.py, test_data_stores.py, test_state_iam.py, test_tfdoc.py, test_check_boilerplate.py, and test_common_functions.sh.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: SA-11, CM-2

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Executed bash tools/run_tests.sh (103 Python unit tests, 28 shell syntax checks, 90 shell unit tests, and CodeQL AST checks pass) and python3 tools/check_boilerplate.py tests tools.

@aghassemlouei aghassemlouei added the Enhancement New feature or request label Oct 20, 2026
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch from 23f65da to e40563b Compare October 20, 2026 04:01
@aghassemlouei aghassemlouei changed the title chore(tests): flatten tests directory and remove redundant wrappers chore(tests): flatten tests directory and expand unit test coverage Oct 20, 2026
Comment thread tests/test_state_iam.py Fixed
@aghassemlouei aghassemlouei changed the title chore(tests): flatten tests directory and expand unit test coverage refactor(tests): flatten test suite into tests/ and expand unit coverage Oct 20, 2026
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch 3 times, most recently from dfb5da5 to 1b2e56a Compare October 20, 2026 15:06
@aghassemlouei
aghassemlouei marked this pull request as ready for review October 20, 2026 15:08
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch from 1b2e56a to e20e450 Compare October 20, 2026 22:33
@aghassemlouei aghassemlouei added Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Scope - Module Related to reusable Terraform modules in the modules directory Scope - Fast Related to Fabric FAST deployment stages in the fast directory Scope - Blueprint Related to solution blueprints in the blueprints directory Status - Ready for Review and removed Status - Ready for Review labels Oct 20, 2026
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch 3 times, most recently from 82cf1fc to fc1c06e Compare October 20, 2026 23:56
@github-actions github-actions Bot added Gemini - Enterprise Gemini Enterprise (GE) related Gemini - Government Gemini for Government (G4G) related labels Oct 20, 2026
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch 3 times, most recently from fc5c577 to 1c4bf9c Compare October 21, 2026 00:18
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch 3 times, most recently from aaaa44a to 390eb83 Compare October 22, 2026 02:14
Calvin-Cheng1
Calvin-Cheng1 previously approved these changes Oct 22, 2026
@aghassemlouei
aghassemlouei force-pushed the refactor/flatten-tests-directory branch from 85a7f71 to 5627b3b Compare October 23, 2026 12:46
@Calvin-Cheng1
Calvin-Cheng1 merged commit 5839cff into main Oct 23, 2026
22 checks passed
@Calvin-Cheng1
Calvin-Cheng1 deleted the refactor/flatten-tests-directory branch October 23, 2026 13:54
@aghassemlouei aghassemlouei mentioned this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Gemini - Enterprise Gemini Enterprise (GE) related Gemini - Government Gemini for Government (G4G) related Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits Scope - Blueprint Related to solution blueprints in the blueprints directory Scope - Fast Related to Fabric FAST deployment stages in the fast directory Scope - Module Related to reusable Terraform modules in the modules directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants