Address Copilot review nits on PR #462

All 5 flagged items were valid (4 real bugs + 1 dead assert),

- fix an inverted `sys.version_info < (3, 14)` guard in
  `ipc._linux` — the "`cffi` has no 3.14 support" import note now
  fires on 3.14+ (where it applies) instead of on older pys.
- use `os.environ.get('PYTHON_COLORS')` in the `sync_bp` example
  so it doesn't `KeyError` when run outside the test harness.
- correct `dump_task_tree()`'s docstring: the `/tmp` + `/dev/tty`
  tee is gated on `write_file`/`write_tty`, not "unconditional".
- tidy the `ActorTooSlowError` message spacing in `cancel_actor`.
- replace a tautological `applied is True or applied is False` in
  `test_patches` with `isinstance(applied, bool)` (the value is
  order-dependent across the module).

Review: PR #462 (copilot-pull-request-reviewer)
#462 (review)

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code

Author: goodboy

examples/debugging/sync_bp.py

@@ -12,7 +12,7 @@
 # disable `pbdp` prompt colors
 # for prompt matching in test.
 def disable_pdbp_color():
-    if os.environ['PYTHON_COLORS'] == '0':
+    if os.environ.get('PYTHON_COLORS') == '0':
         from tractor.devx.debug import _repl
         _repl.TractorConfig.use_pygments = False
 

tests/trionics/test_patches.py

@@ -59,7 +59,7 @@ def test_wakeup_socketpair_drain_eof_patch_works():
     # First call MUST return True; idempotent guard
     # prevents False on subsequent calls within the
     # same process.
-    assert applied is True or applied is False  # idempotent
+    assert isinstance(applied, bool)  # idempotent (order-dependent value)
 
     # Cap wall-clock at 2s; SIGALRM raises in main
     # thread which interrupts the C-level recv loop

tractor/devx/_stackscope.py

@@ -71,17 +71,18 @@ def dump_task_tree(
     Do a classic `stackscope.extract()` task-tree dump to console at
     `.devx()` level.
 
-    Also unconditionally tee the rendered tree to two
-    capture-bypassing sinks so SIGUSR1 dumps remain visible
-    when the parent process has captured stdio (e.g. pytest's
-    default `--capture=fd`):
-
-    - `/tmp/tractor-stackscope-<pid>.log` (append-mode, always
-      written) — guaranteed-readable artifact even under CI
+    When `write_file`/`write_tty` are set, ALSO tee the rendered
+    tree to capture-bypassing sinks so SIGUSR1 dumps remain
+    visible when the parent process has captured stdio (e.g.
+    pytest's default `--capture=fd`); the SIGUSR1 handler passes
+    `write_file=True` for exactly this reason:
+
+    - `write_file` -> `/tmp/tractor-stackscope-<pid>.log`
+      (append-mode) — guaranteed-readable artifact even under CI
       / `nohup` / no-tty conditions. `tail -f` to follow.
-    - `/dev/tty` if a controlling terminal is attached —
-      best-effort, ignored if the device is missing or write
-      fails. pytest never captures the tty.
+    - `write_tty` -> `/dev/tty` if a controlling terminal is
+      attached — best-effort, ignored if the device is missing
+      or write fails. pytest never captures the tty.
 
     '''
     import os

tractor/ipc/_linux.py

@@ -24,7 +24,7 @@
 try:
     import cffi
 except ImportError as ie:
-    if sys.version_info < (3, 14):
+    if sys.version_info >= (3, 14):
         ie.add_note(
             f'The `cffi` pkg has no 3.14 support yet.\n'
         )

tractor/runtime/_portal.py

@@ -340,9 +340,9 @@ async def cancel_actor(
                 raise_on_timeout
             ):
                 raise ActorTooSlowError(
-                    f'Peer {peer_id} did not ack `Actor.cancel()`'
-                    f'-RPC within bounded wait of '
-                    f'{cancel_timeout!r}s'
+                    f'Peer {peer_id} did not ack its '
+                    f'`Actor.cancel()` RPC within bounded wait '
+                    f'of {cancel_timeout!r}s'
                 )
 
             # legacy fire-and-forget path: log + return False so