fix: remove orphan toolset (singular) deprecated property from schema#33360
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix orphan deprecation for toolset in schema
fix: remove orphan May 19, 2026
toolset (singular) deprecated property from schema
Collaborator
|
@copilot run make fmt |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done — |
Collaborator
|
@copilot format code |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the deprecated tools.github.toolset (singular) property from the main workflow JSON schema and to regenerate the editor autocomplete data so that the deprecated entry no longer appears.
Changes:
- Remove
tools.github.toolset(singular) frompkg/parser/schemas/main_workflow_schema.json. - Regenerate
docs/public/editor/autocomplete-data.json, dropping thetoolsetautocomplete entry (and updating other generated entries). - Update a Datadog header placeholder in
.github/workflows/smoke-otel-backends.lock.ymlto use${DD_APP_KEY}forDD_APPLICATION_KEY.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/schemas/main_workflow_schema.json | Removes the deprecated toolset (singular) schema property under tools.github. |
| docs/public/editor/autocomplete-data.json | Regenerated autocomplete snapshot reflecting schema changes (and additional generated diffs). |
| .github/workflows/smoke-otel-backends.lock.yml | Changes Datadog MCP header env placeholder for DD_APPLICATION_KEY. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 3
| @@ -3916,25 +3916,6 @@ | |||
| } | |||
| ] | |||
| }, | |||
Comment on lines
+641
to
+646
| "allowed-input": { | ||
| "type": "boolean", | ||
| "desc": "When true and the workflow uses workflow_call, expose a network_allowed string input on the compiled lock file.", | ||
| "enum": [true, false], | ||
| "leaf": true | ||
| }, |
| "headers": { | ||
| "DD_API_KEY": "\${DD_API_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APPLICATION_KEY}", | ||
| "DD_APPLICATION_KEY": "\${DD_APP_KEY}", |
Contributor
Author
Done — code formatted and committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools.github.toolset(singular) existed in the schema marked deprecated, but the parser never read it — onlytoolsets(plural) is consumed. A user writingtoolset:would silently get no toolset config with no warning or migration.Changes
pkg/parser/schemas/main_workflow_schema.json— removes the deadtoolset(singular) property block entirely; a deprecation entry for a field that never worked is misleadingdocs/public/editor/autocomplete-data.json— regenerated viadocs/scripts/generate-autocomplete-data.jsto drop the corresponding editor autocomplete entry