Reject removed tools.serena in parser and align with schema

[Copilot]

tools.serena was marked as removed in the main workflow schema, but the parser still accepted and configured it as a built-in MCP tool. This change makes parser behavior match the schema contract and provides an explicit migration path.

• Parser/schema contract alignment

  • ExtractMCPConfigurations now rejects top-level tools.serena with a compile-time error.
  • Error message mirrors schema migration guidance to import shared/mcp/serena.md.

• Built-in MCP cleanup

  • Removed serena from built-in tool detection in tools.
  • Deleted Serena-specific built-in MCP config branch from processBuiltinMCPTool (built-ins now only include github and playwright).

• Coverage for removed behavior

  • Added parser test case asserting tools.serena returns an error containing the removal message.

if toolName == "serena" {
    return nil, fmt.Errorf(`tools.serena built-in support has been removed. Import shared/mcp/serena.md instead:
  imports:
    - uses: shared/mcp/serena.md
      with:
        languages: ["go", "typescript"]`)
}

[pelikhan]

@copilot not special treatment, just error

[Copilot]

@copilot not special treatment, just error

Updated in a942a2a. tools.serena now returns a plain parser error (tools.serena is removed) with no special migration formatting.

[Copilot]

Pull request overview

This PR removes parser support for the removed tools.serena built-in MCP tool and adds coverage for rejecting it.

Changes:

• Rejects tools.serena during MCP extraction.
• Removes Serena from built-in MCP tool handling.
• Adds a parser test for the removed Serena behavior and updates the generated smoke workflow lock.

Show a summary per file

File	Description
pkg/parser/mcp.go	Rejects tools.serena and removes Serena built-in MCP configuration logic.
pkg/parser/mcp_test.go	Adds error assertion support and a test case for removed Serena config.
.github/workflows/smoke-claude.lock.yml	Aligns the locked workflow cleanup step with generated checkout cleanup behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/parser/mcp.go:218

• This second tools.serena rejection uses a shorter message than the schema's removal guidance (pkg/parser/schemas/main_workflow_schema.json:4493). Keep both rejection paths on the same full migration message, or factor the message into a shared constant to avoid drift.

				if toolName == "serena" {
					return nil, fmt.Errorf("tools.serena is removed")
				}

• Files reviewed: 3/3 changed files
• Comments generated: 2