Unify OTel engine identity on agent spans and remove duplicate gen_ai.system#32801
Merged
Conversation
7 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve OTel instrumentation: unify gh-aw.engine.id across spans
Unify OTel engine identity on agent spans and remove duplicate May 17, 2026
gen_ai.system
pelikhan
approved these changes
May 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes telemetry attributes for agent spans so engine identity uses gh-aw.engine.id consistently and avoids duplicate gen_ai.system emission.
Changes:
- Removed agent-span-specific emission of
gen_ai.systemandgh-aw.engine. - Updated agent span tests to expect inherited
gh-aw.engine.id. - Added test coverage ensuring
gen_ai.systemappears only once.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/send_otlp_span.cjs |
Removes redundant agent span attributes so shared conclusion attributes provide engine/system identity. |
actions/setup/js/send_otlp_span.test.cjs |
Updates expectations for normalized engine attributes and adds duplicate gen_ai.system coverage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent spans were emitting engine identity under
gh-aw.enginewhile setup/conclusion spans usegh-aw.engine.id, fragmenting cross-span engine queries. Agent spans also emittedgen_ai.systemtwice due to re-adding an attribute already present in inherited attributes.Telemetry attribute normalization
gh-aw.engine.gh-aw.engine.idacross setup, conclusion, and agent spans.Duplicate attribute removal
gen_ai.system.gen_ai.systemvalue (inherited from conclusion attributes).Targeted test updates
gh-aw.enginetogh-aw.engine.id.gen_ai.systemappears exactly once on the agent span.gen_ai.systemfalls back to raw engine ID).