Skip to content

feat: add otel-queries skill for efficient telemetry analysis#31459

Merged
mnkiefer merged 5 commits into
mainfrom
add-otel-queries
May 11, 2026
Merged

feat: add otel-queries skill for efficient telemetry analysis#31459
mnkiefer merged 5 commits into
mainfrom
add-otel-queries

Conversation

@mnkiefer
Copy link
Copy Markdown
Collaborator

@mnkiefer mnkiefer commented May 11, 2026

  • Inspect recent CI failures and local project commands
  • Reproduce lint/format/test issues locally
  • Apply the smallest fixes needed

@mnkiefer mnkiefer self-assigned this May 11, 2026
Copilot AI review requested due to automatic review settings May 11, 2026 08:40
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated “otel-queries” skill and wires it into existing OTel-focused advisor workflows so telemetry investigations follow a consistent, fixed query loop (prefer cheapest trustworthy source → run common queries → only then recommend optimizations).

Changes:

  • Added new skills/otel-queries skill doc defining a standard telemetry analysis loop, query shapes, and local JSONL jq recipes.
  • Included a shared workflow snippet (shared/otel-queries.md) and imported it into the daily OTel instrumentation advisor workflows (and regenerated lock files accordingly).
  • Updated the agentic-workflows router skill and the global skills index to reference the new skill.
Show a summary per file
File Description
skills/otel-queries/SKILL.md New skill playbook for querying/interpreting gh-aw OpenTelemetry data.
AGENTS.md Adds otel-queries to the skills reference list.
.github/workflows/shared/otel-queries.md Shared prompt snippet directing agents to use the new skill for telemetry analysis.
.github/workflows/daily-otel-instrumentation-advisor.md Imports shared/otel-queries.md to standardize telemetry analysis approach.
.github/workflows/daily-otel-instrumentation-advisor.lock.yml Regenerated lock output to include the new shared runtime import.
.github/workflows/daily-grafana-otel-instrumentation-advisor.md Imports shared/otel-queries.md for Grafana-based advisor workflow.
.github/workflows/daily-grafana-otel-instrumentation-advisor.lock.yml Regenerated lock output to include the new shared runtime import.
.github/skills/agentic-workflows/SKILL.md Router skill now points telemetry-driven workflow tasks to the new skill.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 8/8 changed files
  • Comments generated: 2

Comment thread .github/workflows/shared/otel-queries.md Outdated
Comment thread .github/skills/agentic-workflows/SKILL.md Outdated
mnkiefer and others added 2 commits May 11, 2026 10:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ smoke-ci: safeoutputs CLI comment + comment-memory run (25659939637)

Generated by Smoke CI for issue #31459 ·

@mnkiefer
Copy link
Copy Markdown
Collaborator Author

@copilot Make lint and fmt. Fix tests.

Copilot AI and others added 2 commits May 11, 2026 09:15
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot Make lint and fmt. Fix tests.

Addressed in 104d491. make lint, make test-unit, and make test-wasm-golden are passing now.

@github-actions
Copy link
Copy Markdown
Contributor

Hey @mnkiefer 👋 — great to see the new otel-queries skill landing! Adding structured telemetry query support is a solid addition to the agentic workflows toolkit.

A couple of things that would help reviewers:

  • Unfocused diff — the PR bundles the new otel-queries skill (.github/workflows/shared/otel-queries.md, skills/otel-queries/SKILL.md, related workflow files) together with unrelated changes to pkg/cli/forecast.go, pkg/cli/forecast_montecarlo.go, and several golden test data files. Consider splitting the forecast/montecarlo fixes into a separate PR so reviewers can evaluate each concern independently.
  • Missing PR description — the body contains only a task checklist with no narrative explaining what this skill does, why it's being added, or how it works. A short summary would help reviewers and future readers of the git history.

If you'd like a hand, you can assign this prompt to your coding agent:

Split PR #31459 in the github/gh-aw repository into two focused PRs:
1. The otel-queries skill addition: files under .github/workflows/shared/otel-queries.md, .github/workflows/daily-grafana-otel-instrumentation-advisor.*, .github/workflows/daily-otel-instrumentation-advisor.*, skills/otel-queries/SKILL.md, AGENTS.md, and the agentic-workflows SKILL.md update.
2. The forecast/montecarlo fixes: pkg/cli/forecast.go, pkg/cli/forecast_montecarlo.go, pkg/cli/forecast_montecarlo_test.go, pkg/workflow/action_pins_test.go, and the golden test data files.

For each PR, write a proper description that explains: what changed, why it was needed, and any relevant context or linked issues.

Generated by Contribution Check · ● 6.8M ·

@mnkiefer mnkiefer merged commit 83e20bf into main May 11, 2026
50 of 52 checks passed
@mnkiefer mnkiefer deleted the add-otel-queries branch May 11, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants