Skip to content

[jsweep] Clean add_reaction_and_edit_comment.cjs #29439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
May 1, 2026
Merged

[jsweep] Clean add_reaction_and_edit_comment.cjs #29439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions actions/setup/js/add_reaction_and_edit_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,21 +185,16 @@ async function main() {
* @param {string} reaction - The reaction type to add
*/
async function addReaction(endpoint, reaction) {
const response = await github.request("POST " + endpoint, {
const response = await github.request(`POST ${endpoint}`, {
content: reaction,
headers: {
Accept: "application/vnd.github+json",
},
});

const reactionId = response.data?.id;
if (reactionId) {
core.info(`Successfully added reaction: ${reaction} (id: ${reactionId})`);
core.setOutput("reaction-id", reactionId.toString());
} else {
core.info(`Successfully added reaction: ${reaction}`);
core.setOutput("reaction-id", "");
}
core.info(`Successfully added reaction: ${reaction}${reactionId ? ` (id: ${reactionId})` : ""}`);
core.setOutput("reaction-id", reactionId?.toString() ?? "");
}

/**
Expand Down Expand Up @@ -369,7 +364,7 @@ async function addCommentWithWorkflowLink(endpoint, runUrl, eventName, invocatio
}

// Create a new comment for non-discussion events
const createResponse = await github.request("POST " + endpoint, {
const createResponse = await github.request(`POST ${endpoint}`, {
body: commentBody,
headers: {
Accept: "application/vnd.github+json",
Expand All @@ -380,7 +375,7 @@ async function addCommentWithWorkflowLink(endpoint, runUrl, eventName, invocatio
} catch (error) {
// Don't fail the entire job if comment creation fails - just log it
const errorMessage = getErrorMessage(error);
core.warning("Failed to create comment with workflow link (This is not critical - the reaction was still added successfully): " + errorMessage);
core.warning(`Failed to create comment with workflow link (This is not critical - the reaction was still added successfully): ${errorMessage}`);
}
}

Expand Down
Loading