Skip to content

Commit 9eb802c

Browse files
msonnbmsonnb
committed
use 'handler' instead
1 parent 9c70c92 commit 9eb802c

30 files changed

Lines changed: 78 additions & 74 deletions

File tree

‎dev-packages/e2e-tests/test-applications/elysia-bun/tests/transactions.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ test('Creates lifecycle spans for Elysia hooks', async ({ baseURL, request }) =>
132132
expect(spans).toContainEqual(
133133
expect.objectContaining({
134134
description: 'Handle',
135-
op: 'function',
135+
op: 'handler',
136136
origin: 'auto.http.elysia',
137137
}),
138138
);

‎dev-packages/e2e-tests/test-applications/elysia-node/tests/transactions.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ test('Creates lifecycle spans for Elysia hooks', async ({ baseURL, request }) =>
132132
expect(spans).toContainEqual(
133133
expect.objectContaining({
134134
description: 'Handle',
135-
op: 'function',
135+
op: 'handler',
136136
origin: 'auto.http.elysia',
137137
}),
138138
);

‎dev-packages/e2e-tests/test-applications/nestjs-11/tests/transactions.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ test('Sends an API route transaction', async ({ baseURL }) => {
6262
'express.type': 'request_handler',
6363
'http.route': '/test-transaction',
6464
'sentry.origin': 'auto.http.express',
65-
'sentry.op': 'function',
65+
'sentry.op': 'handler',
6666
},
67-
op: 'function',
67+
op: 'handler',
6868
description: '/test-transaction',
6969
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
7070
span_id: expect.stringMatching(/[a-f0-9]{16}/),
@@ -105,7 +105,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
105105
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
106106
data: {
107107
'sentry.origin': 'auto.http.nestjs',
108-
'sentry.op': 'function',
108+
'sentry.op': 'handler',
109109
component: '@nestjs/core',
110110
'nestjs.version': expect.any(String),
111111
'nestjs.type': 'handler',
@@ -117,7 +117,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
117117
timestamp: expect.any(Number),
118118
status: 'ok',
119119
origin: 'auto.http.nestjs',
120-
op: 'function',
120+
op: 'handler',
121121
},
122122
]),
123123
transaction: 'GET /test-transaction',

‎dev-packages/e2e-tests/test-applications/nestjs-8/tests/transactions.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ test('Sends an API route transaction', async ({ baseURL }) => {
6666
'express.type': 'request_handler',
6767
'http.route': '/test-transaction',
6868
'sentry.origin': 'auto.http.express',
69-
'sentry.op': 'function',
69+
'sentry.op': 'handler',
7070
},
71-
op: 'function',
71+
op: 'handler',
7272
description: '/test-transaction',
7373
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
7474
span_id: expect.stringMatching(/[a-f0-9]{16}/),
@@ -109,7 +109,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
109109
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
110110
data: {
111111
'sentry.origin': 'auto.http.nestjs',
112-
'sentry.op': 'function',
112+
'sentry.op': 'handler',
113113
component: '@nestjs/core',
114114
'nestjs.version': expect.any(String),
115115
'nestjs.type': 'handler',
@@ -121,7 +121,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
121121
timestamp: expect.any(Number),
122122
status: 'ok',
123123
origin: 'auto.http.nestjs',
124-
op: 'function',
124+
op: 'handler',
125125
},
126126
]),
127127
transaction: 'GET /test-transaction',

‎dev-packages/e2e-tests/test-applications/nestjs-basic/tests/transactions.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ test('Sends an API route transaction', async ({ baseURL }) => {
8888
'express.type': 'request_handler',
8989
'http.route': '/test-transaction',
9090
'sentry.origin': 'auto.http.express',
91-
'sentry.op': 'function',
91+
'sentry.op': 'handler',
9292
},
93-
op: 'function',
93+
op: 'handler',
9494
description: '/test-transaction',
9595
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
9696
span_id: expect.stringMatching(/[a-f0-9]{16}/),
@@ -131,7 +131,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
131131
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
132132
data: {
133133
'sentry.origin': 'auto.http.nestjs',
134-
'sentry.op': 'function',
134+
'sentry.op': 'handler',
135135
component: '@nestjs/core',
136136
'nestjs.version': expect.any(String),
137137
'nestjs.type': 'handler',
@@ -143,7 +143,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
143143
timestamp: expect.any(Number),
144144
status: 'ok',
145145
origin: 'auto.http.nestjs',
146-
op: 'function',
146+
op: 'handler',
147147
},
148148
]),
149149
transaction: 'GET /test-transaction',

‎dev-packages/e2e-tests/test-applications/nestjs-fastify/tests/transactions.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,14 @@ test.skip('Sends an API route transaction', async ({ baseURL }) => {
8383
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
8484
data: {
8585
'sentry.origin': 'auto.http.otel.fastify',
86-
'sentry.op': 'function',
86+
'sentry.op': 'handler',
8787
'hook.name': 'fastify -> @sentry/instrumentation-fastify -> @fastify/middie - route-handler',
8888
'fastify.type': 'request-handler',
8989
'http.route': '/test-transaction',
9090
'hook.callback.name': 'anonymous',
9191
},
9292
description: '@fastify/middie - route-handler',
93-
op: 'function',
93+
op: 'handler',
9494
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
9595
start_timestamp: expect.any(Number),
9696
timestamp: expect.any(Number),
@@ -125,7 +125,7 @@ test.skip('Sends an API route transaction', async ({ baseURL }) => {
125125
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
126126
data: {
127127
'sentry.origin': 'auto.http.nestjs',
128-
'sentry.op': 'function',
128+
'sentry.op': 'handler',
129129
component: '@nestjs/core',
130130
'nestjs.version': expect.any(String),
131131
'nestjs.type': 'handler',
@@ -136,7 +136,7 @@ test.skip('Sends an API route transaction', async ({ baseURL }) => {
136136
start_timestamp: expect.any(Number),
137137
timestamp: expect.any(Number),
138138
status: 'ok',
139-
op: 'function',
139+
op: 'handler',
140140
origin: 'auto.http.nestjs',
141141
},
142142
{
@@ -799,7 +799,7 @@ test('Sets error status on nest spans when a handler throws', async ({ baseURL }
799799
expect(transactionEvent.spans).toEqual(
800800
expect.arrayContaining([
801801
expect.objectContaining({ op: 'request_context.nestjs', status: 'internal_error' }),
802-
expect.objectContaining({ op: 'function', status: 'internal_error' }),
802+
expect.objectContaining({ op: 'handler', status: 'internal_error' }),
803803
]),
804804
);
805805
});

‎dev-packages/e2e-tests/test-applications/nestjs-orchestrion/tests/transactions.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ test('request_context + handler: a route transaction nests the nestjs spans', as
6060

6161
// request_handler span: wraps the controller method itself.
6262
const handler = (transactionEvent.spans ?? []).find(
63-
span => span.op === 'function' && span.description === 'testTransaction',
63+
span => span.op === 'handler' && span.description === 'testTransaction',
6464
);
6565
expect(handler).toBeDefined();
6666
});

‎dev-packages/e2e-tests/test-applications/nestjs-with-submodules-decorator/tests/transactions.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
6262
'express.type': 'request_handler',
6363
'http.route': '/example-module/transaction',
6464
'sentry.origin': 'auto.http.express',
65-
'sentry.op': 'function',
65+
'sentry.op': 'handler',
6666
},
67-
op: 'function',
67+
op: 'handler',
6868
description: '/example-module/transaction',
6969
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
7070
span_id: expect.stringMatching(/[a-f0-9]{16}/),
@@ -105,7 +105,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
105105
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
106106
data: {
107107
'sentry.origin': 'auto.http.nestjs',
108-
'sentry.op': 'function',
108+
'sentry.op': 'handler',
109109
component: '@nestjs/core',
110110
'nestjs.version': expect.any(String),
111111
'nestjs.type': 'handler',
@@ -117,7 +117,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
117117
timestamp: expect.any(Number),
118118
status: 'ok',
119119
origin: 'auto.http.nestjs',
120-
op: 'function',
120+
op: 'handler',
121121
},
122122
]),
123123
transaction: 'GET /example-module/transaction',

‎dev-packages/e2e-tests/test-applications/nestjs-with-submodules/tests/transactions.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
6262
'express.type': 'request_handler',
6363
'http.route': '/example-module/transaction',
6464
'sentry.origin': 'auto.http.express',
65-
'sentry.op': 'function',
65+
'sentry.op': 'handler',
6666
},
67-
op: 'function',
67+
op: 'handler',
6868
description: '/example-module/transaction',
6969
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
7070
span_id: expect.stringMatching(/[a-f0-9]{16}/),
@@ -105,7 +105,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
105105
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
106106
data: {
107107
'sentry.origin': 'auto.http.nestjs',
108-
'sentry.op': 'function',
108+
'sentry.op': 'handler',
109109
component: '@nestjs/core',
110110
'nestjs.version': expect.any(String),
111111
'nestjs.type': 'handler',
@@ -117,7 +117,7 @@ test('Sends an API route transaction from module', async ({ baseURL }) => {
117117
timestamp: expect.any(Number),
118118
status: 'ok',
119119
origin: 'auto.http.nestjs',
120-
op: 'function',
120+
op: 'handler',
121121
},
122122
]),
123123
transaction: 'GET /example-module/transaction',

‎dev-packages/e2e-tests/test-applications/node-express-esm-loader/tests/server.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ test('Should record a transaction for route with parameters', async ({ request }
102102
'express.type': 'request_handler',
103103
'http.route': '/test-transaction/:param',
104104
'sentry.origin': 'auto.http.express',
105-
'sentry.op': 'function',
105+
'sentry.op': 'handler',
106106
},
107-
op: 'function',
107+
op: 'handler',
108108
description: '/test-transaction/:param',
109109
origin: 'auto.http.express',
110110
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),

0 commit comments

Comments
 (0)