ref(instr): Tag rate limiting time with limiter type (#5356)

Author: Dav1dde

relay-server/src/services/processor.rs

@@ -3014,12 +3014,11 @@ impl RateLimiter {
         }
 
         let scoping = managed_envelope.scoping();
-        let (enforcement, rate_limits) =
-            metric!(timer(RelayTimers::EventProcessingRateLimiting), {
-                envelope_limiter
-                    .compute(managed_envelope.envelope_mut(), &scoping)
-                    .await
-            })?;
+        let (enforcement, rate_limits) = metric!(timer(RelayTimers::EventProcessingRateLimiting), type = self.name(), {
+            envelope_limiter
+                .compute(managed_envelope.envelope_mut(), &scoping)
+                .await
+        })?;
         let event_active = enforcement.is_event_active();
 
         // Use the same rate limits as used for the envelope on the metrics.
@@ -3036,6 +3035,14 @@ impl RateLimiter {
 
         Ok(EnforcementResult::new(event, rate_limits))
     }
+
+    fn name(&self) -> &'static str {
+        match self {
+            Self::Cached => "cached",
+            #[cfg(feature = "processing")]
+            Self::Consistent(_) => "consistent",
+        }
+    }
 }
 
 pub fn encode_payload(body: &Bytes, http_encoding: HttpEncoding) -> Result<Bytes, std::io::Error> {

relay-server/src/statsd.rs

@@ -386,6 +386,9 @@ pub enum RelayTimers {
     /// Not all events reach this point. After an event is rate limited for the first time, the rate
     /// limit is cached. Events coming in after this will be discarded earlier in the request queue
     /// and do not reach the processing queue.
+    ///
+    /// This metric is tagged with:
+    ///  - `type`: The type of limiter executed, `cached` or `consistent`.
     EventProcessingRateLimiting,
     /// Time in milliseconds spent in data scrubbing for the current event. Data scrubbing happens
     /// last before serializing the event back to JSON.