fix(ci): use correct Apple signing secret names#1006
Merged
Conversation
Align CI secret references with the actual secret names set in the production environment: - CSC_LINK → APPLE_CERT_DATA - CSC_KEY_PASSWORD → APPLE_CERT_PASSWORD - vars.APPLE_TEAM_ID → secrets.APPLE_TEAM_ID
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4234 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.87% 81.87% —%
==========================================
Files 328 328 —
Lines 23351 23351 —
Branches 15114 15114 —
==========================================
+ Hits 19117 19117 —
- Misses 4234 4234 —
- Partials 1620 1620 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align CI secret references with the actual secret names set in the production environment:
secrets.CSC_LINK→secrets.APPLE_CERT_DATAsecrets.CSC_KEY_PASSWORD→secrets.APPLE_CERT_PASSWORDvars.APPLE_TEAM_ID→secrets.APPLE_TEAM_IDThe previous names were copied from Spotlight's workflow but the secrets were set with different names in this repo.