Repository navigation
Commit 02265c4
committed
test(trios): unmasking string literals made the aim worse, and it is taken back
The measurement said the narrowing lands right once in four and named the
reason: the spec must name the function. The obvious next evidence was the log
event name - queen.review.verdicts is unique and sits as a literal at line 4595,
inside exactly the function a human had named by hand - and the localiser blanks
literals along with comments, so it could not see it.
Keeping the comment masking and dropping the literal masking measured worse:
browseros-ai#1156 reset() was handleWorkerFinished worse
browseros-ai#1158 acceptanceBlockReason… unchanged
browseros-ai#1165 reset() was chooseNextOpenIssue worse
browseros-ai#1166 reset() unchanged
Three of four in reset(). Literals carry a great many ordinary words, so
unmasking fed the density rule the noise that masking comments had been added to
remove. Sound reasoning, worse result - which is what measuring is for.
Restored to the committed version and re-measured to confirm: browseros-ai#1156 is
handleWorkerFinished again. The score stands at one clean hit and one useful
neighbour out of four.
Refs Trinity-S-AI-DNA/trios#11741 parent 944b226 commit 02265c4
1 file changed
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4361 | 4361 | | |
4362 | 4362 | | |
4363 | 4363 | | |
| 4364 | + | |
| 4365 | + | |
| 4366 | + | |
| 4367 | + | |
| 4368 | + | |
| 4369 | + | |
| 4370 | + | |
| 4371 | + | |
| 4372 | + | |
| 4373 | + | |
| 4374 | + | |
| 4375 | + | |
| 4376 | + | |
| 4377 | + | |
| 4378 | + | |
| 4379 | + | |
| 4380 | + | |
| 4381 | + | |
| 4382 | + | |
| 4383 | + | |
| 4384 | + | |
| 4385 | + | |
| 4386 | + | |
| 4387 | + | |
| 4388 | + | |
| 4389 | + | |
| 4390 | + | |
0 commit comments