From f3030d0de14e27525718f3a2d5525e8d309bc4c7 Mon Sep 17 00:00:00 2001 From: Ben Hagen Date: Sun, 23 Sep 2018 09:42:54 +0200 Subject: [PATCH 1/3] Do not divide by zero --- packages/video_player/ios/Classes/VideoPlayerPlugin.m | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/video_player/ios/Classes/VideoPlayerPlugin.m b/packages/video_player/ios/Classes/VideoPlayerPlugin.m index 7699831710c5..e2168ebf6590 100644 --- a/packages/video_player/ios/Classes/VideoPlayerPlugin.m +++ b/packages/video_player/ios/Classes/VideoPlayerPlugin.m @@ -5,7 +5,10 @@ #import "VideoPlayerPlugin.h" #import -int64_t FLTCMTimeToMillis(CMTime time) { return time.value * 1000 / time.timescale; } +int64_t FLTCMTimeToMillis(CMTime time) { + if (time.timescale == 0) return 0; + return time.value * 1000 / time.timescale; +} @interface FLTFrameUpdater : NSObject @property(nonatomic) int64_t textureId; From c65e04fa5a6401a6ab1e83320f378084c5071c83 Mon Sep 17 00:00:00 2001 From: Maurice Parrish Date: Mon, 4 Mar 2019 14:50:44 -0800 Subject: [PATCH 2/3] Formatting --- packages/video_player/ios/Classes/VideoPlayerPlugin.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/video_player/ios/Classes/VideoPlayerPlugin.m b/packages/video_player/ios/Classes/VideoPlayerPlugin.m index e2168ebf6590..bb1c35b9828e 100644 --- a/packages/video_player/ios/Classes/VideoPlayerPlugin.m +++ b/packages/video_player/ios/Classes/VideoPlayerPlugin.m @@ -6,8 +6,8 @@ #import int64_t FLTCMTimeToMillis(CMTime time) { - if (time.timescale == 0) return 0; - return time.value * 1000 / time.timescale; + if (time.timescale == 0) return 0; + return time.value * 1000 / time.timescale; } @interface FLTFrameUpdater : NSObject From 7e57657244cae991a42ff45143c6ff0c464c8c8e Mon Sep 17 00:00:00 2001 From: Maurice Parrish Date: Mon, 4 Mar 2019 14:55:49 -0800 Subject: [PATCH 3/3] Version bump --- packages/video_player/CHANGELOG.md | 8 ++++++++ packages/video_player/pubspec.yaml | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/video_player/CHANGELOG.md b/packages/video_player/CHANGELOG.md index 6280b9ce47ed..1d635f19d4a8 100644 --- a/packages/video_player/CHANGELOG.md +++ b/packages/video_player/CHANGELOG.md @@ -1,3 +1,11 @@ +## 0.10.0+3 + +* Fix divide by zero bug on iOS. + +## 0.10.0+2 + +* Added supported format documentation in README. + ## 0.10.0+1 * Log a more detailed warning at build time about the previous AndroidX diff --git a/packages/video_player/pubspec.yaml b/packages/video_player/pubspec.yaml index 197430d53585..467b42287862 100644 --- a/packages/video_player/pubspec.yaml +++ b/packages/video_player/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android and iOS. author: Flutter Team -version: 0.10.0+2 +version: 0.10.0+3 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player flutter: