[go_router] Sets correct reverseTransitionDuration on NoTransitionPage (#123368) (#3540)

[go_router] Sets correct reverseTransitionDuration on NoTransitionPage (#123368)

Author: josh-burton

packages/go_router/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 6.5.2
+
+- NoTransitionPage now has an instant reverse transition
+
 ## 6.5.1
 
 - Fixes an issue where the params are removed after popping.

packages/go_router/lib/src/pages/custom_transition_page.dart

@@ -175,7 +175,8 @@ class NoTransitionPage<T> extends CustomTransitionPage<T> {
     super.key,
   }) : super(
           transitionsBuilder: _transitionsBuilder,
-          transitionDuration: const Duration(microseconds: 1),
+          transitionDuration: Duration.zero,
+          reverseTransitionDuration: Duration.zero,
         );
 
   static Widget _transitionsBuilder(

packages/go_router/pubspec.yaml

@@ -1,7 +1,7 @@
 name: go_router
 description: A declarative router for Flutter based on Navigation 2 supporting
   deep linking, data-driven routes and more
-version: 6.5.1
+version: 6.5.2
 repository: https://github.com/flutter/packages/tree/main/packages/go_router
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22
 

packages/go_router/test/custom_transition_page_test.dart

@@ -61,28 +61,59 @@ void main() {
 
     final Finder homeScreenFinder = find.byType(HomeScreen);
 
+    expect(homeScreenFinder, findsNothing);
+
     showHomeValueNotifier.value = true;
+
     await tester.pump();
-    final Offset homeScreenPositionInTheMiddleOfAddition =
-        tester.getTopLeft(homeScreenFinder);
+
+    expect(homeScreenFinder, findsOneWidget);
+
     await tester.pumpAndSettle();
-    final Offset homeScreenPositionAfterAddition =
-        tester.getTopLeft(homeScreenFinder);
 
     showHomeValueNotifier.value = false;
+
     await tester.pump();
-    final Offset homeScreenPositionInTheMiddleOfRemoval =
-        tester.getTopLeft(homeScreenFinder);
+
+    expect(homeScreenFinder, findsNothing);
+
     await tester.pumpAndSettle();
+  });
 
-    expect(
-      homeScreenPositionInTheMiddleOfAddition,
-      homeScreenPositionAfterAddition,
-    );
-    expect(
-      homeScreenPositionAfterAddition,
-      homeScreenPositionInTheMiddleOfRemoval,
+  testWidgets('NoTransitionPage does not apply any reverse transition',
+      (WidgetTester tester) async {
+    final ValueNotifier<bool> showHomeValueNotifier = ValueNotifier<bool>(true);
+    await tester.pumpWidget(
+      MaterialApp(
+        home: ValueListenableBuilder<bool>(
+          valueListenable: showHomeValueNotifier,
+          builder: (_, bool showHome, __) {
+            return Navigator(
+              pages: <Page<void>>[
+                const NoTransitionPage<void>(
+                  child: LoginScreen(),
+                ),
+                if (showHome)
+                  const NoTransitionPage<void>(
+                    child: HomeScreen(),
+                  ),
+              ],
+              onPopPage: (Route<dynamic> route, dynamic result) {
+                return route.didPop(result);
+              },
+            );
+          },
+        ),
+      ),
     );
+
+    final Finder homeScreenFinder = find.byType(HomeScreen);
+
+    showHomeValueNotifier.value = false;
+
+    await tester.pump();
+
+    expect(homeScreenFinder, findsNothing);
   });
 
   testWidgets('Dismiss a screen by tapping a modal barrier',