Commit 6ab9a8b
authored
[google_sign_in] Convert Android to Pigeon (#4344)
Replaces the direct method channel implementation with Pigeon.
Since `google_sign_in`, unlike most of our plugins, exposes an API that's intended for direct cross-plugin native use, the existing methods are all left in place, but refactored as passthroughs to the new Pigeon versions. To ensure that they aren't broken, the existing Java tests are preserved unchanged (as a "legacy" copy) with `onMethodCall` left in place for now just to allow the tests to continue to run as-is. Since that dispatches to the legacy methods, this keeps the existing coverage of those methods.
The new tests are a copy of the legacy tests, minimally translated to use the new Pigeon variants, to ensure continuity of testing to the new version.
Part of flutter/flutter#1179081 parent d3c0d5f commit 6ab9a8b
13 files changed
Lines changed: 2401 additions & 435 deletions
File tree
- packages/google_sign_in/google_sign_in_android
- android/src
- main/java/io/flutter/plugins/googlesignin
- test/java/io/flutter/plugins/googlesignin
- lib
- src
- pigeons
- test
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
Lines changed: 367 additions & 126 deletions
Large diffs are not rendered by default.
0 commit comments