This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Commit c5727d8
Fix path mask caching regression
Adding the explicit rect to the path mask key in:
https://skia-review.googlesource.com/c/skia/+/286902 (Add path bounds to SW path mask key)
prevented the path mask from being reused more generally.
This CL just adds the width & height to the key which allows reuse but still prevents proxy size mismatches due to numerical inaccuracies.
For the path_mask_cache GM we have:
Num Generated Num Reuses
with the bad CL: 24 0
prior to bad CL: 18 6
with this CL: 18 6
Change-Id: I6f5c847e6f14c80013d4f315ef8a9a16c737295b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287816
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>1 parent 1e8fb04 commit c5727d8
1 file changed
Lines changed: 9 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
| 282 | + | |
283 | 283 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
| 284 | + | |
| 285 | + | |
288 | 286 | | |
289 | 287 | | |
290 | 288 | | |
| |||
299 | 297 | | |
300 | 298 | | |
301 | 299 | | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
306 | 304 | | |
307 | 305 | | |
308 | 306 | | |
309 | 307 | | |
310 | 308 | | |
311 | 309 | | |
312 | | - | |
313 | | - | |
| 310 | + | |
| 311 | + | |
314 | 312 | | |
315 | 313 | | |
316 | 314 | | |
| |||
0 commit comments