Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 77c53d2

Browse files
author
Harry Terkelsen
authored
Default the CanvasKit base URL to local artifacts. (#40293)
1 parent 8e58041 commit 77c53d2

4 files changed

Lines changed: 1 addition & 207 deletions

File tree

lib/web_ui/README.md

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -197,34 +197,6 @@ Resources:
197197
2. LUCI web [recipe][5]
198198
3. More general reading on CIPD packages [link][6]
199199

200-
### Rolling CanvasKit
201-
202-
CanvasKit is versioned separately from Skia and rolled manually. Flutter
203-
consumes a pre-built CanvasKit provided by the Skia team, currently hosted on
204-
unpkg.com. When a new version of CanvasKit is available (check
205-
https://www.npmjs.com/package/canvaskit-wasm or consult the Skia team
206-
directly), follow these steps to roll to the new version:
207-
208-
- Make sure you have `depot_tools` installed (if you are regularly hacking on
209-
the engine code, you probably do).
210-
- If not already authenticated with CIPD, run `cipd auth-login` and follow
211-
instructions (this step requires sufficient privileges; file a github
212-
infra ticket queue issue: https://github.com/flutter/flutter/wiki/Infra-Ticket-Queue
213-
to get access)
214-
- Edit `dev/canvaskit_lock.yaml` and update the value of `canvaskit_version`
215-
to the new version.
216-
- Run `dart dev/canvaskit_roller.dart` and make sure it completes successfully.
217-
The script uploads the new version of CanvasKit to the
218-
`flutter/web/canvaskit_bundle` CIPD package, and writes the CIPD package
219-
instance ID to the DEPS file.
220-
- Rerun `gclient sync` and do a clean build to test that the new version is
221-
picked up.
222-
- Send a pull request containing the above file changes. If the new version
223-
contains breaking changes, the PR must also contain corresponding fixes.
224-
225-
If you have questions, contact the Flutter Web team on Flutter Discord on the
226-
#hackers-web-🌍 channel.
227-
228200
### Rolling Noto Font Data
229201

230202
In order to generate new data for the Noto fallback fonts, you will need

lib/web_ui/dev/canvaskit_lock.yaml

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/web_ui/dev/canvaskit_roller.dart

Lines changed: 0 additions & 169 deletions
This file was deleted.

lib/web_ui/lib/src/engine/configuration.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,6 @@ import 'package:meta/meta.dart';
4949
import 'canvaskit/renderer.dart';
5050
import 'dom.dart';
5151

52-
/// The version of CanvasKit used by the web engine by default.
53-
// DO NOT EDIT THE NEXT LINE OF CODE MANUALLY
54-
// See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.
55-
const String _canvaskitVersion = '0.38.0';
56-
5752
/// The Web Engine configuration for the current application.
5853
FlutterConfiguration get configuration =>
5954
_configuration ??= FlutterConfiguration.legacy(_jsConfiguration);
@@ -182,7 +177,7 @@ class FlutterConfiguration {
182177
String get canvasKitBaseUrl => _configuration?.canvasKitBaseUrl ?? _defaultCanvasKitBaseUrl;
183178
static const String _defaultCanvasKitBaseUrl = String.fromEnvironment(
184179
'FLUTTER_WEB_CANVASKIT_URL',
185-
defaultValue: 'https://unpkg.com/canvaskit-wasm@$_canvaskitVersion/bin/',
180+
defaultValue: 'canvaskit/',
186181
);
187182

188183
/// The variant of CanvasKit to download.

0 commit comments

Comments
 (0)