Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 24cf93e

Browse files
authored
Revert "Add elevation and thickness to SemanticsNode (#7282)" (#7483)
This reverts commit 6c29fb4.
1 parent 6c29fb4 commit 24cf93e

4 files changed

Lines changed: 0 additions & 22 deletions

File tree

lib/ui/semantics.dart

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -607,14 +607,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
607607
///
608608
/// The `transform` is a matrix that maps this node's coordinate system into
609609
/// its parent's coordinate system.
610-
///
611-
/// The `elevation` describes the distance in z-direction between this node
612-
/// and the `elevation` of the parent.
613-
///
614-
/// The `thickness` describes how much space this node occupies in the
615-
/// z-direction starting at `elevation`. Basically, in the z-direction the
616-
/// node starts at `elevation` above the parent and ends at `elevation` +
617-
/// `thickness` above the parent.
618610
void updateNode({
619611
int id,
620612
int flags,
@@ -626,8 +618,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
626618
double scrollPosition,
627619
double scrollExtentMax,
628620
double scrollExtentMin,
629-
double elevation,
630-
double thickness,
631621
Rect rect,
632622
String label,
633623
String hint,
@@ -657,8 +647,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
657647
rect.top,
658648
rect.right,
659649
rect.bottom,
660-
elevation,
661-
thickness,
662650
label,
663651
hint,
664652
value,
@@ -686,8 +674,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
686674
double top,
687675
double right,
688676
double bottom,
689-
double elevation,
690-
double thickness,
691677
String label,
692678
String hint,
693679
String value,

lib/ui/semantics/semantics_node.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ struct SemanticsNode {
8787
double scrollPosition = std::nan("");
8888
double scrollExtentMax = std::nan("");
8989
double scrollExtentMin = std::nan("");
90-
double elevation = 0.0;
91-
double thickness = 0.0;
9290
std::string label;
9391
std::string hint;
9492
std::string value;

lib/ui/semantics/semantics_update_builder.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ void SemanticsUpdateBuilder::updateNode(
5050
double top,
5151
double right,
5252
double bottom,
53-
double elevation,
54-
double thickness,
5553
std::string label,
5654
std::string hint,
5755
std::string value,
@@ -74,8 +72,6 @@ void SemanticsUpdateBuilder::updateNode(
7472
node.scrollExtentMax = scrollExtentMax;
7573
node.scrollExtentMin = scrollExtentMin;
7674
node.rect = SkRect::MakeLTRB(left, top, right, bottom);
77-
node.elevation = elevation;
78-
node.thickness = thickness;
7975
node.label = label;
8076
node.hint = hint;
8177
node.value = value;

lib/ui/semantics/semantics_update_builder.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ class SemanticsUpdateBuilder
3838
double top,
3939
double right,
4040
double bottom,
41-
double elevation,
42-
double thickness,
4341
std::string label,
4442
std::string hint,
4543
std::string value,

0 commit comments

Comments
 (0)