[nnbd] Fix remaining analyzer issues in dart:io and dart:_http.

Change-Id: I419b54962fde1a6bd4efd9ea58d81cf29a8bd45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140103
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>

Author: sortie

pkg/dev_compiler/tool/dart2js_nnbd_sdk_error_golden.txt

@@ -6,14 +6,6 @@ ERROR|COMPILE_TIME_ERROR|INCONSISTENT_INHERITANCE|lib/_internal/js_runtime/lib/i
 ERROR|COMPILE_TIME_ERROR|INCONSISTENT_INHERITANCE|lib/_internal/js_runtime/lib/interceptors.dart|1637|7|5|Superinterfaces don't have a valid override for '>>': int.>> (int Function(int)), JSNumber.>> (num Function(num)).
 ERROR|COMPILE_TIME_ERROR|INCONSISTENT_INHERITANCE|lib/_internal/js_runtime/lib/interceptors.dart|1637|7|5|Superinterfaces don't have a valid override for '\|': int.\| (int Function(int)), JSNumber.\| (num Function(num)).
 ERROR|COMPILE_TIME_ERROR|INCONSISTENT_INHERITANCE|lib/_internal/js_runtime/lib/interceptors.dart|1637|7|5|Superinterfaces don't have a valid override for '^': int.^ (int Function(int)), JSNumber.^ (num Function(num)).
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1010|10|5|Non-nullable instance field 'value' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1036|8|6|Non-nullable instance field 'secure' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1042|8|8|Non-nullable instance field 'httpOnly' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1499|12|11|Non-nullable instance field 'idleTimeout' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1549|8|14|Non-nullable instance field 'autoUncompress' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|172|8|12|Non-nullable instance field 'autoCompress' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|997|10|4|Non-nullable instance field 'name' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/io/io.dart|5589|12|8|Non-nullable instance field 'encoding' must be initialized.
 ERROR|STATIC_TYPE_WARNING|UNDEFINED_OPERATOR|lib/_internal/js_runtime/lib/interceptors.dart|1654|28|1|The operator '&' isn't defined for the type 'JSInt'.
 ERROR|STATIC_TYPE_WARNING|UNDEFINED_OPERATOR|lib/_internal/js_runtime/lib/interceptors.dart|1656|27|1|The operator '&' isn't defined for the type 'JSInt'.
 ERROR|STATIC_TYPE_WARNING|UNDEFINED_OPERATOR|lib/_internal/js_runtime/lib/interceptors.dart|1659|17|1|The operator '&' isn't defined for the type 'JSInt'.

pkg/dev_compiler/tool/dartdevc_nnbd_sdk_error_golden.txt

@@ -15,11 +15,3 @@ ERROR|COMPILE_TIME_ERROR|BODY_MIGHT_COMPLETE_NORMALLY|lib/_internal/js_dev_runti
 ERROR|COMPILE_TIME_ERROR|BODY_MIGHT_COMPLETE_NORMALLY|lib/_internal/js_dev_runtime/private/foreign_helper.dart|221|8|37|The body might complete normally, which would cause 'null' to be returned, but the return type is a potentially non-nullable type.
 ERROR|COMPILE_TIME_ERROR|BODY_MIGHT_COMPLETE_NORMALLY|lib/_internal/js_dev_runtime/private/foreign_helper.dart|224|8|11|The body might complete normally, which would cause 'null' to be returned, but the return type is a potentially non-nullable type.
 ERROR|COMPILE_TIME_ERROR|BODY_MIGHT_COMPLETE_NORMALLY|lib/_internal/js_dev_runtime/private/foreign_helper.dart|228|6|11|The body might complete normally, which would cause 'null' to be returned, but the return type is a potentially non-nullable type.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1010|10|5|Non-nullable instance field 'value' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1036|8|6|Non-nullable instance field 'secure' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1042|8|8|Non-nullable instance field 'httpOnly' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1499|12|11|Non-nullable instance field 'idleTimeout' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|1549|8|14|Non-nullable instance field 'autoUncompress' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|172|8|12|Non-nullable instance field 'autoCompress' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/_http/http.dart|997|10|4|Non-nullable instance field 'name' must be initialized.
-ERROR|COMPILE_TIME_ERROR|NOT_INITIALIZED_NON_NULLABLE_INSTANCE_FIELD|lib/io/io.dart|5589|12|8|Non-nullable instance field 'encoding' must be initialized.

sdk_nnbd/lib/_http/http.dart

@@ -142,7 +142,8 @@ abstract class HttpServer implements Stream<HttpRequest> {
    *
    * The default value is `null`.
    */
-  String? serverHeader;
+  String? get serverHeader;
+  void set serverHeader(String? newServerHeader);
 
   /**
    * Default set of headers added to all response objects.
@@ -169,7 +170,8 @@ abstract class HttpServer implements Stream<HttpRequest> {
    * The default value is `false` (compression disabled).
    * To enable, set `autoCompress` to `true`.
    */
-  bool autoCompress;
+  bool get autoCompress;
+  void set autoCompress(bool newAutoCompress);
 
   /**
    * Gets or sets the timeout used for idle keep-alive connections. If no
@@ -183,7 +185,8 @@ abstract class HttpServer implements Stream<HttpRequest> {
    *
    * To disable, set [idleTimeout] to `null`.
    */
-  Duration? idleTimeout;
+  Duration? get idleTimeout;
+  void set idleTimeout(Duration? newIdleTimeout);
 
   /**
    * Starts listening for HTTP requests on the specified [address] and
@@ -994,7 +997,8 @@ abstract class Cookie {
    * `(`, `)`, `<`, `>`, `@`, `,`, `;`, `:`, `\`, `"`, `/`, `[`, `]`, `?`, `=`,
    * `{`, and `}`.
    */
-  String name;
+  String get name;
+  void set name(String newName);
 
   /**
    * The value of the cookie.
@@ -1007,39 +1011,46 @@ abstract class Cookie {
    * Cookie values may be wrapped in a single pair of double quotes
    * (U+0022, `"`).
    */
-  String value;
+  String get value;
+  void set value(String newValue);
 
   /**
    * The time at which the cookie expires.
    */
-  DateTime? expires;
+  DateTime? get expires;
+  void set expires(DateTime? newExpires);
 
   /**
    * The number of seconds until the cookie expires. A zero or negative value
    * means the cookie has expired.
    */
-  int? maxAge;
+  int? get maxAge;
+  void set maxAge(int? newMaxAge);
 
   /**
    * The domain that the cookie applies to.
    */
-  String? domain;
+  String? get domain;
+  void set domain(String? newDomain);
 
   /**
    * The path within the [domain] that the cookie applies to.
    */
-  String? path;
+  String? get path;
+  void set path(String? newPath);
 
   /**
    * Whether to only send this cookie on secure connections.
    */
-  bool secure;
+  bool get secure;
+  void set secure(bool newSecure);
 
   /**
    * Whether the cookie is only sent in the HTTP request and is not made
    * available to client side scripts.
    */
-  bool httpOnly;
+  bool get httpOnly;
+  void set httpOnly(bool newHttpOnly);
 
   /**
    * Creates a new cookie setting the name and value.
@@ -1496,7 +1507,8 @@ abstract class HttpClient {
   /// connections.
   ///
   /// The default value is 15 seconds.
-  Duration idleTimeout;
+  Duration get idleTimeout;
+  void set idleTimeout(Duration newIdleTimeout);
 
   /// Gets and sets the connection timeout.
   ///
@@ -1506,7 +1518,8 @@ abstract class HttpClient {
   ///
   /// When this is `null`, the OS default timeout is used. The default is
   /// `null`.
-  Duration? connectionTimeout;
+  Duration? get connectionTimeout;
+  void set connectionTimeout(Duration? newConnectionTimeout);
 
   /**
    * Gets and sets the maximum number of live connections, to a single host.
@@ -1518,7 +1531,8 @@ abstract class HttpClient {
    *
    * Default is `null`.
    */
-  int? maxConnectionsPerHost;
+  int? get maxConnectionsPerHost;
+  void set maxConnectionsPerHost(int? newMaxConnectionsPerHost);
 
   /**
    * Gets and sets whether the body of a response will be automatically
@@ -1546,7 +1560,8 @@ abstract class HttpClient {
    *
    * Default is `true`.
    */
-  bool autoUncompress;
+  bool get autoUncompress;
+  void set autoUncompress(bool newAutoUncompress);
 
   /// Gets and sets the default value of the `User-Agent` header for all requests
   /// generated by this [HttpClient].
@@ -1555,7 +1570,8 @@ abstract class HttpClient {
   ///
   /// If the userAgent is set to `null`, no default `User-Agent` header will be
   /// added to each request.
-  String? userAgent;
+  String? get userAgent;
+  void set userAgent(String? newUserAgent);
 
   factory HttpClient({SecurityContext? context}) {
     HttpOverrides? overrides = HttpOverrides.current;

sdk_nnbd/lib/io/io_sink.dart

@@ -31,7 +31,8 @@ abstract class IOSink implements StreamSink<List<int>>, StringSink {
    * The [Encoding] used when writing strings. Depending on the
    * underlying consumer this property might be mutable.
    */
-  Encoding encoding;
+  Encoding get encoding;
+  void set encoding(Encoding newEncoding);
 
   /**
    * Adds byte [data] to the target consumer, ignoring [encoding].