Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

Commit cb86254

Browse files
committed
feat(build): #1108 document contributing
Add new sections to the contributing.md file to help newcomers. - Running your local changes - Adding yourself to the mailmap - Validating commit message - DCO - Adding and rendering documentation Update lintMarkdown config. Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
1 parent 97ccd84 commit cb86254

2 files changed

Lines changed: 41 additions & 10 deletions

File tree

docs/src/contributing.md

Lines changed: 40 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,48 @@ We can discuss implementation details [here][makes_issues].
1919
1. [Git][git]-push changes to your fork
2020
1. Create a **Pull Request** from your fork to [Makes][makes]
2121

22-
Guidelines:
22+
### Testing your local changes
2323

24-
- Keep it simple
25-
- Remember we write code for humans, not machines
26-
- Write an argument: `/src/args`
27-
- Write a module (if applies): `/src/evaluator/modules`
28-
- Write docs: `/README.md` or `/docs`
29-
- Write a test: `/makes.nix` or `/makes/**/main.nix`
30-
- Write a test [GitHub workflow][github_workflows]: `/.github/workflows/dev.yml`
24+
You can run local changes by simply running `m . <job>`.
25+
If you're adding new files, make sure to `git add` them first.
3126

32-
Examples:
27+
### Adding documentation
28+
29+
- All changes must be documented in the same PR.
30+
- You can run `m . /docs/dev` to serve the [docs site](https://makes.fluidattacks.com)
31+
on localhost.
32+
- Make sure you lint the documentation with `m . /lintMarkdown/all`.
33+
34+
### Adding tests
35+
36+
- All new [builtins](https://makes.fluidattacks.com/api/builtins/) must be
37+
tested.
38+
- You can add tests to either `/makes.nix` or `/makes/your-builtin/main.nix`
39+
depending on the nature of the builtin.
40+
- Make sure to add such tests to the [GitHub Actions pipelines as well](https://github.com/fluidattacks/makes/tree/main/.github/workflows).
41+
42+
### Adding yourself to the mailmap
43+
44+
You must add yourself to the
45+
[.mailmap](https://github.com/fluidattacks/makes/blob/main/.mailmap) file.
46+
Make sure to test it with `m . /lintGitMailMap`.
47+
48+
### Writing a valid commit message
49+
50+
- Your commit message must follow this [syntax](https://github.com/fluidattacks/makes/tree/main/test/lint-commit-msg).
51+
- You must sign your commits by adding a `Signed-off-by` line at the end of your
52+
commit message.
53+
- You can take a look at other commits [here](https://github.com/fluidattacks/makes/commits/main).
54+
- Make sure to test it with `m . /lintGitCommitMsg`.
55+
56+
### Other PR rules
57+
58+
A PR must:
59+
60+
- Only be one commit ahead of main.
61+
- Have a title and body equal to its commmit message.
62+
63+
### Examples
3364

3465
- [feat(build): #262 lint git mailmap](https://github.com/fluidattacks/makes/commit/01fcd5790dd54b117da63bcc2480437135da8bb3)
3566
- [feat(build): #232 lint terraform](https://github.com/fluidattacks/makes/commit/081835b563c712b7650dbc5bf1e306d4aff159cf)

test/lint-markdown/config.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
rule 'MD010'
1010
rule 'MD011'
1111
rule 'MD012'
12-
rule 'MD013', :tables => false, :code_blocks => false
12+
rule 'MD013', :tables => false, :ignore_code_blocks => true
1313
rule 'MD018'
1414
rule 'MD019'
1515
rule 'MD020'

0 commit comments

Comments
 (0)