fix: centralize cache file registry#1370
Merged
Merged
Conversation
floatpanebot
added
bug
Member
andrinoff
reviewed
May 28, 2026
Member
There was a problem hiding this comment.
collectDataFiles still has the directory names hardcoded (also in bodyDir and sigDir) loop over them too
Member
Author
|
The |
FromSi
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the hardcoded file list inside
MigrateCacheFiles()with two package-level registries:cacheFilesfor JSON cache files andcacheDirectoriesfor cache subdirectories.Why?
Previously, adding a new cache file to the project required finding and updating the hardcoded list inside
MigrateCacheFiles(). This was easy to forget and caused files to be silently left behind in the old~/.config/matcha/location after migration. Now there is a single obvious place to register new cache paths.Closes #564