-
Notifications
You must be signed in to change notification settings - Fork 981
Add setup_Experience_platform notes for ipa #50632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melpike let me know if you disagree with
I just sort of guessed. The alternative is we just say that setup_experience: true defaults to ipados or both ios and ipados is an option as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JordanMontgomery Just to clarify, we SHOULD support the
setup_experienceboolean flag on IPA entries in GitOps?If that is set to
trueand nosetup_experience_platformsexist, then we only mark it as setup for iOS? Or should we just ignore that value and only letsetup_experience_platformsdecide?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this as documented and made the changes in my PR. But yes, would want to know more and have a clarity on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagnusHJensen Yes we should support setup_experience: true for these and default to iOS. The idea was just to more or less match script only package behavior which default to a specific platform when you do that. Some more discussion here: https://fleetdm.slack.com/archives/C03C41L5YEL/p1785872604636629?thread_ts=1785872215.845759&cid=C03C41L5YEL
IMHO ideally a customer would just use setup_experience_platforms but I think this is the most consistent thing we can do for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raju249 Based on my testing this does not work in your PR as it stands right now. Let me know if maybe my testing was off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagnusHJensen - This PR #51135 actually delivers the app to the device.
#51124 just supports the CRUD, thats it. Does not add the send-to-device part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm referring to the GitOps
setup_experience: truewhich should be part of #51124, and based on my last test is not handled properly.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! got it. Yes, the fresh app lands on iOS, but already existing apps, with just the boolean landed on iPadOS due to ordering issue in the query and the upload code happens to insert the iPadOS row first. Fixed it in the same PR. My bad to miss this case.