Skip to content

Commit 1ec24c3

Browse files
authored
Merge pull request #701 from fixrtm/improve-soundpack-compatiblity
Improve soundpack compatiblity
2 parents 6292f0d + 0c40ada commit 1ec24c3

5 files changed

Lines changed: 31 additions & 129 deletions

File tree

CHANGELOG-SNAPSHOTS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ The changelog for 2.0.23 and earlier is generated by [anatawa12's fork of `auto-
1919

2020
### Fixed
2121
- Speaker setting is not saved correctly `#697`
22+
- Some sound pack broken `#701`
2223

2324
### Security
2425

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ Thanks to prepare-changelog.sh, we have some macros.
2626

2727
### Fixed
2828
- Speaker setting is not saved correctly `#697`
29+
- Some sound pack broken `#701`
2930

3031
### Security
3132

src/main/java/com/anatawa12/fixRtm/rtm/modelpack/RTMResourcePack.kt

Lines changed: 0 additions & 123 deletions
This file was deleted.

src/main/rtm-patches/jp/ngt/rtm/RTMSound.java.patch

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
SimpleReloadableResourceManager simplereloadableresourcemanager = (SimpleReloadableResourceManager)NGTUtilClient.getMinecraft().getResourceManager();
1313
Set<String> set = simplereloadableresourcemanager.getResourceDomains();
1414
List<File> list = new ArrayList<>();
15-
@@ -53,21 +54,22 @@
15+
@@ -53,21 +54,20 @@
1616
list.add(file2);
1717
set.add(file2.getName());
1818
}
@@ -30,11 +30,8 @@
3030
- Map map = getDomainResourceManagers(simplereloadableresourcemanager);
3131
-
3232
for(File file3 : list) {
33-
- RTMResourceManager rtmresourcemanager = new RTMResourceManager(getMetadataSerializer(simplereloadableresourcemanager), file3);
33+
RTMResourceManager rtmresourcemanager = new RTMResourceManager(getMetadataSerializer(simplereloadableresourcemanager), file3);
3434
- map.put(file3.getName(), rtmresourcemanager);
35-
+ net.minecraft.client.resources.FallbackResourceManager rtmresourcemanager =
36-
+ new net.minecraft.client.resources.FallbackResourceManager(simplereloadableresourcemanager.rmMetadataSerializer);
37-
+ rtmresourcemanager.addResourcePack(com.anatawa12.fixRtm.rtm.modelpack.FixRTMResourcePack.createPack(file3.getName(), file3));
3835
+ simplereloadableresourcemanager.domainResourceManagers.put(file3.getName(), rtmresourcemanager);
3936
NGTLog.debug("[RTMSound] Add new domain : " + file3.getName());
4037
}

src/main/rtm-patches/jp/ngt/rtm/modelpack/RTMResourceManager.java.patch

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,32 @@
11
--- a/jp/ngt/rtm/modelpack/RTMResourceManager.java
22
+++ b/jp/ngt/rtm/modelpack/RTMResourceManager.java
3-
@@ -50,22 +50,11 @@
3+
@@ -21,22 +21,23 @@
4+
import net.minecraft.util.ResourceLocation;
5+
import net.minecraftforge.fml.relauncher.Side;
6+
import net.minecraftforge.fml.relauncher.SideOnly;
7+
8+
@SideOnly(Side.CLIENT)
9+
-public final class RTMResourceManager implements IResourceManager {
10+
+public final class RTMResourceManager extends net.minecraft.client.resources.FallbackResourceManager implements IResourceManager {
11+
private final Map<ResourceLocation, IResource> resourceCache = new HashMap();
12+
private final MetadataSerializer serializer;
13+
private final File domain;
14+
15+
public RTMResourceManager(MetadataSerializer par1, File par2) {
16+
+ super(par1);
17+
this.serializer = par1;
18+
this.domain = par2;
19+
}
20+
21+
public Set getResourceDomains() {
22+
- return null;
23+
+ return java.util.Collections.<String>emptySet();
24+
}
25+
26+
public IResource getResource(ResourceLocation par1) throws IOException {
27+
if (this.domain == null) {
28+
throw new FileNotFoundException(par1.toString());
29+
@@ -50,22 +51,11 @@
430
if (!s1.isEmpty()) {
531
String s3 = NGTFileLoader.getArchivePath(s, s1);
632
String s2 = par1.getPath();

0 commit comments

Comments
 (0)