React DOM: Add support for Invoker Commands API - #36493
Open
MaxwellCohen wants to merge 3 commits into
Open
Conversation
MaxwellCohen
marked this pull request as draft
May 20, 2026 21:53
MaxwellCohen
marked this pull request as ready for review
May 20, 2026 22:27
MaxwellCohen
commented
May 21, 2026
| document.body.removeChild(element); | ||
| } | ||
| }, | ||
| overrideStringValue: 'popover-target', |
Contributor
Author
There was a problem hiding this comment.
I am reusing 'popover-target' ID be because the common use case for the invoker API is popovers. If I should change it let me know.
Contributor
Author
|
@eps1lon or @rickhanlonii, this is ready for review. If you would be so kind, could you take a look at this PR? |
MaxwellCohen
force-pushed
the
feat/invoker-command-api
branch
from
May 26, 2026 22:15
ed96b81 to
b900475
Compare
This commit adds a new test case to verify that the commandFor attribute is correctly set on button elements. It ensures that the attribute is rendered as expected in the DOM. Additionally, it modifies the handling of the commandFor property in the ReactDOMComponent to allow for better error handling in development mode.
MaxwellCohen
force-pushed
the
feat/invoker-command-api
branch
from
July 27, 2026 02:56
b900475 to
5330d37
Compare
|
Comparing: dcd4ec2...850b077 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
…s API This commit removes the outdated test for the 'onCommand' event and adds a new test case to verify the hydration of Invoker Commands API attributes. It also updates the handling of the 'commandFor' attribute in ReactDOMComponent to improve attribute setting. Additionally, it clarifies the non-bubbling behavior of the 'command' event in the SimpleEventPlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This includes support for commandfor, command, and oncommand event. The events are only triggered by elements that match the invoker command API.
The Invoker Commands API is currently supported in all major browsers (Chrome, Safari, Firefox)
I designed this PR to match React DOM: Add support for Popover API #27981 as closely as possible, with as few changes as possible.
fixes: #32478
How did you test this change?
Open Questions/Concerns
I leverage Composer 2.5 LLM to help me create this PR and reviewed every line