Prevent incorrect options SSR hydrate mismatch, fix #11602#12088
Closed
t4deu wants to merge 1 commit intofacebook:masterfrom
Closed
Prevent incorrect options SSR hydrate mismatch, fix #11602#12088t4deu wants to merge 1 commit intofacebook:masterfrom
t4deu wants to merge 1 commit intofacebook:masterfrom
Conversation
Avoid overwrite options children nodes when setting the selected option.
Author
|
Hi @gaearon, if possible, could you review this PR please, thank you so much! |
Collaborator
|
Thanks for the PR. I don't think this was the right fix, but it looks like #13261 took care of this. I'll add a regression test based on your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix #11602, the warning "Text content did not match", when hydrating a select with a value.
Caused by a regression that overwrites the children nodes of a option when setting the selected option. As you can see here, the previous version only overwrites the
selectedpropBefore submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn test-prodto test in the production environment. It supports the same options as yarn test.yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).