Update on "[compiler] Add Identifier.declarationId"

Adds `Identifier.declarationId` and the new `DeclarationId` (simulated) opaque type. DeclarationId allows uniquely identifying a variable in the original source, ie regardless of reassignments. This allows us to stay in SSA form throughout compilation (see next diff) while still being able to distinguish SSA versions (via IdentifierId) and non-SSA versions (DeclarationId).

[ghstack-poisoned]

Author: josephsavona

compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts

@@ -1213,7 +1213,7 @@ export type ValidIdentifierName = string & {
   [opaqueValidIdentifierName]: 'ValidIdentifierName';
 };
 
-export function makeTemporary(
+export function makeTemporaryIdentifier(
   id: IdentifierId,
   loc: SourceLocation,
 ): Identifier {

compiler/packages/babel-plugin-react-compiler/src/HIR/HIRBuilder.ts

@@ -28,7 +28,7 @@ import {
   makeDeclarationId,
   makeIdentifierName,
   makeInstructionId,
-  makeTemporary,
+  makeTemporaryIdentifier,
   makeType,
 } from './HIR';
 import {printInstruction} from './PrintHIR';
@@ -184,7 +184,7 @@ export default class HIRBuilder {
 
   makeTemporary(loc: SourceLocation): Identifier {
     const id = this.nextIdentifierId;
-    return makeTemporary(id, loc);
+    return makeTemporaryIdentifier(id, loc);
   }
 
   #resolveBabelBinding(
@@ -891,18 +891,9 @@ export function createTemporaryPlace(
   env: Environment,
   loc: SourceLocation,
 ): Place {
-  const id = env.nextIdentifierId;
   return {
     kind: 'Identifier',
-    identifier: {
-      id,
-      declarationId: makeDeclarationId(id),
-      mutableRange: {start: makeInstructionId(0), end: makeInstructionId(0)},
-      name: null,
-      scope: null,
-      type: makeType(),
-      loc,
-    },
+    identifier: makeTemporaryIdentifier(env.nextIdentifierId, loc),
     reactive: false,
     effect: Effect.Unknown,
     loc: GeneratedSource,

fixtures/flight/package.json

@@ -4,7 +4,7 @@
   "version": "0.1.0",
   "private": true,
   "devEngines": {
-    "node": "20.x || 21.x"
+    "node": "20.x || 22.x"
   },
   "dependencies": {
     "@babel/core": "^7.16.0",

package.json

@@ -103,7 +103,7 @@
     "yargs": "^15.3.1"
   },
   "devEngines": {
-    "node": "16.x || 18.x || 20.x || 21.x"
+    "node": "16.x || 18.x || 20.x || 22.x"
   },
   "jest": {
     "testRegex": "/scripts/jest/dont-run-jest-directly\\.js$"