Skip to content

Commit 7c948d3

Browse files
yungstersyungsters
committed
Enable enableUnifiedSyncLane for React Native (Meta) (#29052)
## Summary Enables the `enableUnifiedSyncLane` feature flag for React Native (Meta). ## How did you test this change? ``` $ yarn test $ yarn flow fabric ``` DiffTrain build for commit 5f28f51.
1 parent 8290a1f commit 7c948d3

7 files changed

Lines changed: 42 additions & 64 deletions

File tree

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2c022b847ed2171c59d37db9f71b394e0082ae3f
1+
5f28f517593558f543683cbf0ff1bd7f48569f16

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<992be7ad266e7af316abc8834205d869>>
10+
* @generated SignedSource<<ca956efb4aaf22602f53006d2b2ee8b9>>
1111
*/
1212

1313
'use strict';
@@ -1997,7 +1997,6 @@ var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
19971997
enableDeferRootSchedulingToMicrotask = dynamicFlags.enableDeferRootSchedulingToMicrotask,
19981998
enableInfiniteRenderLoopDetection = dynamicFlags.enableInfiniteRenderLoopDetection,
19991999
enableRefAsProp = dynamicFlags.enableRefAsProp,
2000-
enableUnifiedSyncLane = dynamicFlags.enableUnifiedSyncLane,
20012000
passChildrenWhenCloningPersistedNodes = dynamicFlags.passChildrenWhenCloningPersistedNodes; // The rest of the flags are static for better dead code elimination.
20022001
var enableAsyncActions = true;
20032002
var enableSchedulingProfiler = true;
@@ -3262,7 +3261,7 @@ var DefaultHydrationLane =
32623261
var DefaultLane =
32633262
/* */
32643263
32;
3265-
var SyncUpdateLanes = enableUnifiedSyncLane ? SyncLane | InputContinuousLane | DefaultLane : SyncLane;
3264+
var SyncUpdateLanes = SyncLane | InputContinuousLane | DefaultLane ;
32663265
var TransitionHydrationLane =
32673266
/* */
32683267
64;
@@ -3417,7 +3416,7 @@ var nextTransitionLane = TransitionLane1;
34173416
var nextRetryLane = RetryLane1;
34183417

34193418
function getHighestPriorityLanes(lanes) {
3420-
if (enableUnifiedSyncLane) {
3419+
{
34213420
var pendingSyncLanes = lanes & SyncUpdateLanes;
34223421

34233422
if (pendingSyncLanes !== 0) {
@@ -4000,7 +3999,7 @@ function getBumpedLaneForHydration(root, renderLanes) {
40003999
var renderLane = getHighestPriorityLane(renderLanes);
40014000
var lane;
40024001

4003-
if (enableUnifiedSyncLane && (renderLane & SyncUpdateLanes) !== NoLane) {
4002+
if ((renderLane & SyncUpdateLanes) !== NoLane) {
40044003
lane = SyncHydrationLane;
40054004
} else {
40064005
switch (renderLane) {
@@ -26088,7 +26087,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2608826087
return root;
2608926088
}
2609026089

26091-
var ReactVersion = '19.0.0-beta-8cbbbfb0';
26090+
var ReactVersion = '19.0.0-beta-79d761af';
2609226091

2609326092
/*
2609426093
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bf7fa797d0242d954cf0ad22f15590ac>>
10+
* @generated SignedSource<<3c9da8b1a20c2a64d5902762d2d5248f>>
1111
*/
1212

1313
"use strict";
@@ -977,7 +977,6 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
977977
enableInfiniteRenderLoopDetection =
978978
dynamicFlagsUntyped.enableInfiniteRenderLoopDetection,
979979
enableRefAsProp = dynamicFlagsUntyped.enableRefAsProp,
980-
enableUnifiedSyncLane = dynamicFlagsUntyped.enableUnifiedSyncLane,
981980
passChildrenWhenCloningPersistedNodes =
982981
dynamicFlagsUntyped.passChildrenWhenCloningPersistedNodes,
983982
emptyObject$1 = {},
@@ -1353,14 +1352,11 @@ function clz32Fallback(x) {
13531352
x >>>= 0;
13541353
return 0 === x ? 32 : (31 - ((log(x) / LN2) | 0)) | 0;
13551354
}
1356-
var SyncUpdateLanes = enableUnifiedSyncLane ? 42 : 2,
1357-
nextTransitionLane = 128,
1355+
var nextTransitionLane = 128,
13581356
nextRetryLane = 4194304;
13591357
function getHighestPriorityLanes(lanes) {
1360-
if (enableUnifiedSyncLane) {
1361-
var pendingSyncLanes = lanes & SyncUpdateLanes;
1362-
if (0 !== pendingSyncLanes) return pendingSyncLanes;
1363-
}
1358+
var pendingSyncLanes = lanes & 42;
1359+
if (0 !== pendingSyncLanes) return pendingSyncLanes;
13641360
switch (lanes & -lanes) {
13651361
case 1:
13661362
return 1;
@@ -6009,8 +6005,7 @@ function updateSuspenseComponent(current, workInProgress, renderLanes) {
60096005
JSCompiler_temp = workInProgressRoot;
60106006
if (null !== JSCompiler_temp) {
60116007
nextProps = renderLanes & -renderLanes;
6012-
if (enableUnifiedSyncLane && 0 !== (nextProps & SyncUpdateLanes))
6013-
nextProps = 1;
6008+
if (0 !== (nextProps & 42)) nextProps = 1;
60146009
else
60156010
switch (nextProps) {
60166011
case 2:
@@ -9842,7 +9837,7 @@ function commitRootImpl(
98429837
remainingLanes = root.pendingLanes;
98439838
(enableInfiniteRenderLoopDetection &&
98449839
(didIncludeRenderPhaseUpdate || didIncludeCommitPhaseUpdate)) ||
9845-
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & SyncUpdateLanes))
9840+
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & 42))
98469841
? root === rootWithNestedUpdates
98479842
? nestedUpdateCount++
98489843
: ((nestedUpdateCount = 0), (rootWithNestedUpdates = root))
@@ -10584,7 +10579,7 @@ var roots = new Map(),
1058410579
devToolsConfig$jscomp$inline_1124 = {
1058510580
findFiberByHostInstance: getInstanceFromNode,
1058610581
bundleType: 0,
10587-
version: "19.0.0-beta-0e5aa221",
10582+
version: "19.0.0-beta-086e14ed",
1058810583
rendererPackageName: "react-native-renderer",
1058910584
rendererConfig: {
1059010585
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10627,7 +10622,7 @@ var internals$jscomp$inline_1356 = {
1062710622
scheduleRoot: null,
1062810623
setRefreshHandler: null,
1062910624
getCurrentFiber: null,
10630-
reconcilerVersion: "19.0.0-beta-0e5aa221"
10625+
reconcilerVersion: "19.0.0-beta-086e14ed"
1063110626
};
1063210627
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1063310628
var hook$jscomp$inline_1357 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<79240e3cc80ad4ba1c6a4a8fd2e22e28>>
10+
* @generated SignedSource<<0374c4a21842dbd2133ac56c8fae0c36>>
1111
*/
1212

1313
"use strict";
@@ -981,7 +981,6 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
981981
enableInfiniteRenderLoopDetection =
982982
dynamicFlagsUntyped.enableInfiniteRenderLoopDetection,
983983
enableRefAsProp = dynamicFlagsUntyped.enableRefAsProp,
984-
enableUnifiedSyncLane = dynamicFlagsUntyped.enableUnifiedSyncLane,
985984
passChildrenWhenCloningPersistedNodes =
986985
dynamicFlagsUntyped.passChildrenWhenCloningPersistedNodes,
987986
emptyObject$1 = {},
@@ -1429,7 +1428,6 @@ function clz32Fallback(x) {
14291428
x >>>= 0;
14301429
return 0 === x ? 32 : (31 - ((log(x) / LN2) | 0)) | 0;
14311430
}
1432-
var SyncUpdateLanes = enableUnifiedSyncLane ? 42 : 2;
14331431
function getLabelForLane(lane) {
14341432
if (lane & 1) return "SyncHydrationLane";
14351433
if (lane & 2) return "Sync";
@@ -1449,10 +1447,8 @@ function getLabelForLane(lane) {
14491447
var nextTransitionLane = 128,
14501448
nextRetryLane = 4194304;
14511449
function getHighestPriorityLanes(lanes) {
1452-
if (enableUnifiedSyncLane) {
1453-
var pendingSyncLanes = lanes & SyncUpdateLanes;
1454-
if (0 !== pendingSyncLanes) return pendingSyncLanes;
1455-
}
1450+
var pendingSyncLanes = lanes & 42;
1451+
if (0 !== pendingSyncLanes) return pendingSyncLanes;
14561452
switch (lanes & -lanes) {
14571453
case 1:
14581454
return 1;
@@ -6215,8 +6211,7 @@ function updateSuspenseComponent(current, workInProgress, renderLanes) {
62156211
JSCompiler_temp = workInProgressRoot;
62166212
if (null !== JSCompiler_temp) {
62176213
nextProps = renderLanes & -renderLanes;
6218-
if (enableUnifiedSyncLane && 0 !== (nextProps & SyncUpdateLanes))
6219-
nextProps = 1;
6214+
if (0 !== (nextProps & 42)) nextProps = 1;
62206215
else
62216216
switch (nextProps) {
62226217
case 2:
@@ -10461,7 +10456,7 @@ function commitRootImpl(
1046110456
remainingLanes = root.pendingLanes;
1046210457
(enableInfiniteRenderLoopDetection &&
1046310458
(didIncludeRenderPhaseUpdate || didIncludeCommitPhaseUpdate)) ||
10464-
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & SyncUpdateLanes))
10459+
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & 42))
1046510460
? ((nestedUpdateScheduled = !0),
1046610461
root === rootWithNestedUpdates
1046710462
? nestedUpdateCount++
@@ -11289,7 +11284,7 @@ var roots = new Map(),
1128911284
devToolsConfig$jscomp$inline_1204 = {
1129011285
findFiberByHostInstance: getInstanceFromNode,
1129111286
bundleType: 0,
11292-
version: "19.0.0-beta-6dfa24ac",
11287+
version: "19.0.0-beta-d0d9e719",
1129311288
rendererPackageName: "react-native-renderer",
1129411289
rendererConfig: {
1129511290
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11345,7 +11340,7 @@ var roots = new Map(),
1134511340
scheduleRoot: null,
1134611341
setRefreshHandler: null,
1134711342
getCurrentFiber: null,
11348-
reconcilerVersion: "19.0.0-beta-6dfa24ac"
11343+
reconcilerVersion: "19.0.0-beta-d0d9e719"
1134911344
});
1135011345
exports.createPortal = function (children, containerTag) {
1135111346
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c616f3c5557c8235bca7c732a1bd4ad9>>
10+
* @generated SignedSource<<474b9244c3c9a13025741c295280cf4c>>
1111
*/
1212

1313
'use strict';
@@ -2343,8 +2343,7 @@ var alwaysThrottleRetries = dynamicFlags.alwaysThrottleRetries,
23432343
disableStringRefs = dynamicFlags.disableStringRefs,
23442344
enableDeferRootSchedulingToMicrotask = dynamicFlags.enableDeferRootSchedulingToMicrotask,
23452345
enableInfiniteRenderLoopDetection = dynamicFlags.enableInfiniteRenderLoopDetection,
2346-
enableRefAsProp = dynamicFlags.enableRefAsProp,
2347-
enableUnifiedSyncLane = dynamicFlags.enableUnifiedSyncLane;
2346+
enableRefAsProp = dynamicFlags.enableRefAsProp;
23482347
// The rest of the flags are static for better dead code elimination.
23492348
var enableAsyncActions = true;
23502349
var enableSchedulingProfiler = true;
@@ -4054,7 +4053,7 @@ var DefaultHydrationLane =
40544053
var DefaultLane =
40554054
/* */
40564055
32;
4057-
var SyncUpdateLanes = enableUnifiedSyncLane ? SyncLane | InputContinuousLane | DefaultLane : SyncLane;
4056+
var SyncUpdateLanes = SyncLane | InputContinuousLane | DefaultLane ;
40584057
var TransitionHydrationLane =
40594058
/* */
40604059
64;
@@ -4209,7 +4208,7 @@ var nextTransitionLane = TransitionLane1;
42094208
var nextRetryLane = RetryLane1;
42104209

42114210
function getHighestPriorityLanes(lanes) {
4212-
if (enableUnifiedSyncLane) {
4211+
{
42134212
var pendingSyncLanes = lanes & SyncUpdateLanes;
42144213

42154214
if (pendingSyncLanes !== 0) {
@@ -4792,7 +4791,7 @@ function getBumpedLaneForHydration(root, renderLanes) {
47924791
var renderLane = getHighestPriorityLane(renderLanes);
47934792
var lane;
47944793

4795-
if (enableUnifiedSyncLane && (renderLane & SyncUpdateLanes) !== NoLane) {
4794+
if ((renderLane & SyncUpdateLanes) !== NoLane) {
47964795
lane = SyncHydrationLane;
47974796
} else {
47984797
switch (renderLane) {
@@ -26438,7 +26437,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2643826437
return root;
2643926438
}
2644026439

26441-
var ReactVersion = '19.0.0-beta-ddb899dd';
26440+
var ReactVersion = '19.0.0-beta-f6541054';
2644226441

2644326442
/*
2644426443
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<40e897e52212d86ac96cac9227ed5e6e>>
10+
* @generated SignedSource<<579d7df14fefede0635f3015ce4ffc4b>>
1111
*/
1212

1313
"use strict";
@@ -1121,7 +1121,6 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
11211121
enableInfiniteRenderLoopDetection =
11221122
dynamicFlagsUntyped.enableInfiniteRenderLoopDetection,
11231123
enableRefAsProp = dynamicFlagsUntyped.enableRefAsProp,
1124-
enableUnifiedSyncLane = dynamicFlagsUntyped.enableUnifiedSyncLane,
11251124
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
11261125
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
11271126
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
@@ -1699,14 +1698,11 @@ function clz32Fallback(x) {
16991698
x >>>= 0;
17001699
return 0 === x ? 32 : (31 - ((log(x) / LN2) | 0)) | 0;
17011700
}
1702-
var SyncUpdateLanes = enableUnifiedSyncLane ? 42 : 2,
1703-
nextTransitionLane = 128,
1701+
var nextTransitionLane = 128,
17041702
nextRetryLane = 4194304;
17051703
function getHighestPriorityLanes(lanes) {
1706-
if (enableUnifiedSyncLane) {
1707-
var pendingSyncLanes = lanes & SyncUpdateLanes;
1708-
if (0 !== pendingSyncLanes) return pendingSyncLanes;
1709-
}
1704+
var pendingSyncLanes = lanes & 42;
1705+
if (0 !== pendingSyncLanes) return pendingSyncLanes;
17101706
switch (lanes & -lanes) {
17111707
case 1:
17121708
return 1;
@@ -6032,8 +6028,7 @@ function updateSuspenseComponent(current, workInProgress, renderLanes) {
60326028
JSCompiler_temp = workInProgressRoot;
60336029
if (null !== JSCompiler_temp) {
60346030
nextProps = renderLanes & -renderLanes;
6035-
if (enableUnifiedSyncLane && 0 !== (nextProps & SyncUpdateLanes))
6036-
nextProps = 1;
6031+
if (0 !== (nextProps & 42)) nextProps = 1;
60376032
else
60386033
switch (nextProps) {
60396034
case 2:
@@ -10024,7 +10019,7 @@ function commitRootImpl(
1002410019
remainingLanes = root.pendingLanes;
1002510020
(enableInfiniteRenderLoopDetection &&
1002610021
(didIncludeRenderPhaseUpdate || didIncludeCommitPhaseUpdate)) ||
10027-
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & SyncUpdateLanes))
10022+
(0 !== (lanes & 4194218) && 0 !== (remainingLanes & 42))
1002810023
? root === rootWithNestedUpdates
1002910024
? nestedUpdateCount++
1003010025
: ((nestedUpdateCount = 0), (rootWithNestedUpdates = root))
@@ -10773,7 +10768,7 @@ var roots = new Map(),
1077310768
devToolsConfig$jscomp$inline_1192 = {
1077410769
findFiberByHostInstance: getInstanceFromTag,
1077510770
bundleType: 0,
10776-
version: "19.0.0-beta-f099a637",
10771+
version: "19.0.0-beta-f1237942",
1077710772
rendererPackageName: "react-native-renderer",
1077810773
rendererConfig: {
1077910774
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10816,7 +10811,7 @@ var internals$jscomp$inline_1441 = {
1081610811
scheduleRoot: null,
1081710812
setRefreshHandler: null,
1081810813
getCurrentFiber: null,
10819-
reconcilerVersion: "19.0.0-beta-f099a637"
10814+
reconcilerVersion: "19.0.0-beta-f1237942"
1082010815
};
1082110816
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1082210817
var hook$jscomp$inline_1442 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)