Bugfix: Synchronous ping during render phase sometimes unwinds the stack, leading to crash (#25851)

I found this bug when working on a different task.

`pingSuspendedRoot` sometimes calls `prepareFreshStack` to interupt the
work-in-progress tree and force a restart from the root. The idea is
that if the current render is already in a state where it be blocked
from committing, and there's new data that could unblock it, we might as
well restart from the beginning.

The problem is that this is only safe to do if `pingSuspendedRoot` is
called from a non-React task, like an event handler or a microtask.
While this is usually the case, it's entirely possible for a thenable to
resolve (i.e. to call `pingSuspendedRoot`) synchronously while the
render phase is already executing. If that happens, and work loop
attempts to unwind the stack, it causes the render phase to crash.

DiffTrain build for [5fcf1a4](5fcf1a4)
[View git log for this commit](https://github.com/facebook/react/commits/5fcf1a4b4c2150a1b9fe0de0144a82a053c63966)

Author: acdlite

compiled/facebook-www/REVISION

@@ -1 +1 @@
-2b1fb91a55deb9b7b60452cb57184c2f182a42fd
+5fcf1a4b4c2150a1b9fe0de0144a82a053c63966

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-2b1fb91a55deb9b7b60452cb57184c2f182a42fd
+5fcf1a4b4c2150a1b9fe0de0144a82a053c63966

compiled/facebook-www/React-dev.classic.js

@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
+var ReactVersion = "18.3.0-www-classic-5fcf1a4b4-20221221";
 
 // ATTENTION
 // When adding new symbols to this file,

compiled/facebook-www/React-dev.modern.js

@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
+var ReactVersion = "18.3.0-www-modern-5fcf1a4b4-20221221";
 
 // ATTENTION
 // When adding new symbols to this file,

compiled/facebook-www/React-prod.classic.js

@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-2b1fb91a5-20221220";
+exports.version = "18.3.0-www-classic-5fcf1a4b4-20221221";

compiled/facebook-www/React-prod.modern.js

@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-2b1fb91a5-20221220";
+exports.version = "18.3.0-www-modern-5fcf1a4b4-20221221";

compiled/facebook-www/React-profiling.classic.js

@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-2b1fb91a5-20221220";
+exports.version = "18.3.0-www-classic-5fcf1a4b4-20221221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

compiled/facebook-www/React-profiling.modern.js

@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-2b1fb91a5-20221220";
+exports.version = "18.3.0-www-modern-5fcf1a4b4-20221221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

compiled/facebook-www/ReactART-dev.classic.js

@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-2b1fb91a5-20221220";
+var ReactVersion = "18.3.0-www-classic-5fcf1a4b4-20221221";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -25766,8 +25766,11 @@ function pingSuspendedRoot(root, wakeable, pingedLanes) {
         includesOnlyRetries(workInProgressRootRenderLanes) &&
         now() - globalMostRecentFallbackTime < FALLBACK_THROTTLE_MS)
     ) {
-      // Restart from the root.
-      prepareFreshStack(root, NoLanes);
+      // Force a restart from the root by unwinding the stack. Unless this is
+      // being called from the render phase, because that would cause a crash.
+      if ((executionContext & RenderContext) === NoContext) {
+        prepareFreshStack(root, NoLanes);
+      }
     } else {
       // Even though we can't restart right now, we might get an
       // opportunity later. So we mark this render as having a ping.

compiled/facebook-www/ReactART-dev.modern.js

@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-2b1fb91a5-20221220";
+var ReactVersion = "18.3.0-www-modern-5fcf1a4b4-20221221";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -25455,8 +25455,11 @@ function pingSuspendedRoot(root, wakeable, pingedLanes) {
         includesOnlyRetries(workInProgressRootRenderLanes) &&
         now() - globalMostRecentFallbackTime < FALLBACK_THROTTLE_MS)
     ) {
-      // Restart from the root.
-      prepareFreshStack(root, NoLanes);
+      // Force a restart from the root by unwinding the stack. Unless this is
+      // being called from the render phase, because that would cause a crash.
+      if ((executionContext & RenderContext) === NoContext) {
+        prepareFreshStack(root, NoLanes);
+      }
     } else {
       // Even though we can't restart right now, we might get an
       // opportunity later. So we mark this render as having a ping.