Skip to content

Commit 3013afe

Browse files
troydemonbreunaweary
authored andcommitted
Fix for #7170 (#7486)
* Write failing test * Ensure .min and .max are set before .value * Adjusting test for false negative * Revert test adjustment (apparently it was only failing locally)
1 parent 9a48b5c commit 3013afe

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/renderers/dom/client/wrappers/ReactDOMInput.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ var ReactDOMInput = {
6767
// Make sure we set .step before .value (setting .value before .step
6868
// means .value is rounded on mount, based upon step precision)
6969
step: undefined,
70+
// Make sure we set .min & .max before .value (to ensure proper order
71+
// in corner cases such as min or max deriving from value, e.g. Issue #7170)
72+
min: undefined,
73+
max: undefined,
7074
}, DisabledInputUtils.getHostProps(inst, props), {
7175
defaultChecked: undefined,
7276
defaultValue: undefined,

src/renderers/dom/client/wrappers/__tests__/ReactDOMInput-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ describe('ReactDOMInput', function() {
742742
);
743743
});
744744

745-
it('sets type and step before value always', function() {
745+
it('sets type, step, min, max before value always', function() {
746746
if (!ReactDOMFeatureFlags.useCreateElement) {
747747
return;
748748
}
@@ -769,10 +769,10 @@ describe('ReactDOMInput', function() {
769769
'set data-reactroot',
770770
'set type',
771771
'set step',
772-
'set value',
773772
'set min',
774773
'set max',
775774
'set value',
775+
'set value',
776776
'set checked',
777777
'set checked',
778778
]);

0 commit comments

Comments
 (0)