Skip to content

Commit f0f046f

Browse files
author
Shinping Bai
committed
Fixes #9777 Add support for resource-id
Track react tag using android.view.View.tag. Allow developers to set resource id by setting component.testID This pull request fixes the following issue. #9777 First, you need to declare the resource id by creating /_your_android_studio_folder_/res/values/ids.xml ``` <?xml version="1.0" encoding="utf-8"?> <resources> <item type="id" name="my_test_id"/> </resources> ``` Second, set the testID of your component to a resource name. ``` <Button onPress={onButtonPress} title="Press Me" testID='test_id' /> ``` Third, run the app and observe the resource id using UIAutomator viewer (/Android/sdk/tools/bin/uiautomatorviewer) This PR doesn't require a documentation change. [ANDROID] [BUGFIX] [com/facebook/react/uimanager/BaseViewManager] - Allow developers to set resource id by setting component.testID
1 parent 1ae19f5 commit f0f046f

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactAppTestActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import com.facebook.react.uimanager.ViewManager;
4242
import com.facebook.react.uimanager.ViewManagerRegistry;
4343
import com.facebook.react.uimanager.events.EventDispatcher;
44+
import com.facebook.react.uimanager.util.ReactFindViewUtil;
4445
import java.util.Arrays;
4546
import com.facebook.react.uimanager.util.ReactFindViewUtil;
4647
import java.util.List;

ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import com.facebook.react.uimanager.UIManagerModule;
1515
import com.facebook.react.uimanager.util.ReactFindViewUtil;
1616
import com.facebook.react.uimanager.events.EventDispatcher;
17+
import com.facebook.react.uimanager.util.ReactFindViewUtil;
1718

1819
/**
1920
* Helper class that deals with emitting Scroll Events.

ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.facebook.react.uimanager.annotations.ReactProp;
2525
import com.facebook.react.uimanager.util.ReactFindViewUtil;
2626
import com.facebook.react.uimanager.events.EventDispatcher;
27+
import com.facebook.react.uimanager.util.ReactFindViewUtil;
2728
import com.facebook.yoga.YogaMeasureFunction;
2829
import com.facebook.yoga.YogaMeasureMode;
2930
import com.facebook.yoga.YogaMeasureOutput;

ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitchManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.facebook.react.uimanager.annotations.ReactProp;
2323
import com.facebook.react.uimanager.util.ReactFindViewUtil;
2424
import com.facebook.react.uimanager.events.EventDispatcher;
25+
import com.facebook.react.uimanager.util.ReactFindViewUtil;
2526
import com.facebook.yoga.YogaMeasureFunction;
2627
import com.facebook.yoga.YogaMeasureMode;
2728
import com.facebook.yoga.YogaMeasureOutput;

0 commit comments

Comments
 (0)