Skip to content

Commit d890f84

Browse files
huntiefacebook-github-bot
authored andcommitted
Switch to new release workflow as default (#43533)
Summary: Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch. - Remove `--use-new-workflow` flag and remove legacy logic. - Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D55027120
1 parent 7e6ca59 commit d890f84

File tree

9 files changed

+43
-337
lines changed

9 files changed

+43
-337
lines changed

.circleci/config.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,10 @@ parameters:
1212
default: false
1313
type: boolean
1414

15-
# Experimental unified release workflow
16-
run_new_release_workflow:
17-
default: false
18-
type: boolean
19-
2015
run_nightly_workflow:
2116
default: false
2217
type: boolean
2318

24-
release_latest:
25-
default: false
26-
type: boolean
27-
2819
release_version:
2920
default: ""
3021
type: string

.circleci/configurations/jobs.yml

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,43 +1076,10 @@ jobs:
10761076
# -------------------------
10771077
# JOBS: Releases
10781078
# -------------------------
1079-
prepare_package_for_release:
1080-
parameters:
1081-
version:
1082-
type: string
1083-
latest:
1084-
type: boolean
1085-
default: false
1086-
dryrun:
1087-
type: boolean
1088-
default: false
1089-
executor: reactnativeios
1090-
steps:
1091-
- checkout_code_with_cache
1092-
- run_yarn
1093-
- add_ssh_keys:
1094-
fingerprints:
1095-
- "1f:c7:61:c4:e2:ff:77:e3:cc:ca:a7:34:c2:79:e3:3c"
1096-
- brew_install:
1097-
package: cmake
1098-
- run:
1099-
name: "Set new react-native version and commit changes"
1100-
command: |
1101-
VERSION=<< parameters.version >>
1102-
1103-
if [[ -z "$VERSION" ]]; then
1104-
VERSION=$(grep '"version"' package.json | cut -d '"' -f 4 | head -1)
1105-
echo "Using the version from the package.json: $VERSION"
1106-
fi
1107-
1108-
node ./scripts/releases-ci/prepare-package-for-release.js -v "$VERSION" -l << parameters.latest >> --dry-run << parameters.dryrun >>
11091079

1110-
# Experimental unified release workflow
1111-
# Replaces `prepare_package_for_release`
1112-
#
11131080
# Writes a new commit and tag(s), which will trigger the `publish_release`
11141081
# and `publish_bumped_packages` workflows.
1115-
prepare_release_new:
1082+
prepare_release:
11161083
parameters:
11171084
version:
11181085
type: string

.circleci/configurations/test_workflows/testAll.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
- equal: [ false, << pipeline.parameters.run_release_workflow >> ]
55
- equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
66
jobs:
7-
- prepare_package_for_release:
8-
name: prepare_package_for_release
9-
version: ''
10-
latest : false
11-
dryrun: true
7+
- prepare_release:
8+
name: "prepare_release (dry run test)"
9+
version: "0.0.0"
10+
monorepo_packages_version: "0.0.0"
11+
tag: latest
12+
dry_run: true
1213
- prepare_hermes_workspace
1314
- build_android:
1415
release_type: "dry-run"

.circleci/configurations/test_workflows/testAndroid.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
- equal: [ false, << pipeline.parameters.run_release_workflow >> ]
55
- equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
66
jobs:
7-
- prepare_package_for_release:
8-
name: prepare_package_for_release
9-
version: ''
10-
latest : false
11-
dryrun: true
7+
- prepare_release:
8+
name: "prepare_release (dry run test)"
9+
version: "0.0.0"
10+
monorepo_packages_version: "0.0.0"
11+
tag: latest
12+
dry_run: true
1213
- prepare_hermes_workspace
1314
- build_android:
1415
release_type: "dry-run"

.circleci/configurations/test_workflows/testIOS.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44
- equal: [ false, << pipeline.parameters.run_release_workflow >> ]
55
- equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
66
jobs:
7-
- prepare_package_for_release:
8-
name: prepare_package_for_release
9-
version: ''
10-
latest : false
11-
dryrun: true
7+
- prepare_release:
8+
name: "prepare_release (dry run test)"
9+
version: "0.0.0"
10+
monorepo_packages_version: "0.0.0"
11+
tag: latest
12+
dry_run: true
1213
- prepare_hermes_workspace
1314
- build_android:
1415
release_type: "dry-run"

.circleci/configurations/top_level.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,18 +129,10 @@ parameters:
129129
default: false
130130
type: boolean
131131

132-
run_new_release_workflow:
133-
default: false
134-
type: boolean
135-
136132
run_nightly_workflow:
137133
default: false
138134
type: boolean
139135

140-
release_latest:
141-
default: false
142-
type: boolean
143-
144136
release_version:
145137
default: ""
146138
type: string

.circleci/configurations/workflows.yml

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# when:
77
# and:
88
# - equal: [ false, << pipeline.parameters.run_release_workflow >> ]
9-
# - equal: [ false, << pipeline.parameters.run_new_release_workflow >> ]
109
# - equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
1110
#
1211
# It's setup this way so we can trigger a release via a POST
@@ -16,22 +15,12 @@
1615
workflows:
1716
version: 2
1817

19-
# This workflow should only be triggered by release script
20-
package_release:
18+
# Release workflow, triggered by `yarn trigger-react-native-release`
19+
create_release:
2120
when: << pipeline.parameters.run_release_workflow >>
2221
jobs:
23-
# This job will push a tag that will trigger the publish_release workflow
24-
- prepare_package_for_release:
25-
name: prepare_package_for_release
26-
version: << pipeline.parameters.release_version >>
27-
latest : << pipeline.parameters.release_latest >>
28-
29-
# Experimental unified release workflow
30-
create_release_new:
31-
when: << pipeline.parameters.run_new_release_workflow >>
32-
jobs:
33-
- prepare_release_new:
34-
name: prepare_release_new
22+
- prepare_release:
23+
name: prepare_release
3524
version: << pipeline.parameters.release_version >>
3625
monorepo_packages_version: << pipeline.parameters.release_monorepo_packages_version >>
3726
tag: << pipeline.parameters.release_tag >>
@@ -91,7 +80,6 @@ workflows:
9180
when:
9281
and:
9382
- equal: [ false, << pipeline.parameters.run_release_workflow >> ]
94-
- equal: [ false, << pipeline.parameters.run_new_release_workflow >> ]
9583
- equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
9684
jobs:
9785
# Run lints on every commit
@@ -141,7 +129,6 @@ workflows:
141129
when:
142130
and:
143131
- equal: [ false, << pipeline.parameters.run_release_workflow >> ]
144-
- equal: [ false, << pipeline.parameters.run_new_release_workflow >> ]
145132
- equal: [ false, << pipeline.parameters.run_nightly_workflow >> ]
146133
jobs:
147134
- find_and_publish_bumped_packages:

scripts/releases-ci/prepare-package-for-release.js

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)