fix(hermes-inspector-modern): Apply HERMES_V1_ENABLED define to all build types (#55312)

Summary:
The HERMES_V1_ENABLED compile option was incorrectly scoped inside the else() block, meaning it only applied to Release builds. This caused Debug builds to fail with missing header errors:

  fatal error: 'hermes/inspector/RuntimeAdapter.h' file not found

This happens when Expo builds Hermes in release mode but WITH the debugger enabled.

Moved the HERMES_V1_ENABLED compile definition into the centralized target_compile_reactnative_options function in react-native-flags.cmake, eliminating duplicate conditional blocks across 7 CMakeLists.txt files.

This ensures the define is consistently applied to all targets that use
target_compile_reactnative_options when HERMES_V1_ENABLED is set, and makes the codebase easier to maintain.

Files cleaned up:
- ReactCommon/cmake-utils/react-native-flags.cmake (added centralized logic)
- ReactCommon/hermes/inspector-modern/CMakeLists.txt
- ReactCommon/hermes/executor/CMakeLists.txt
- ReactCommon/react/runtime/CMakeLists.txt
- ReactCommon/react/runtime/hermes/CMakeLists.txt
- ReactAndroid/.../hermes/reactexecutor/CMakeLists.txt
- ReactAndroid/.../runtime/hermes/jni/CMakeLists.txt
- ReactAndroid/.../runtime/jni/CMakeLists.txt

## Changelog:

[ANDROID] [FIXED] - Fixed so that all build types get the HERMES_V1_ENABLED flag

Pull Request resolved: #55312

Test Plan: Build RN Tester with HERMES_V1

Reviewed By: cipolleschi

Differential Revision: D91581367

Pulled By: cortinico

fbshipit-source-id: fa39158009dadda32438bc04a59579459da2cf7d

Author: chrfalch

packages/react-native/ReactAndroid/src/main/jni/react/hermes/reactexecutor/CMakeLists.txt

@@ -27,8 +27,4 @@ target_link_libraries(
 target_compile_reactnative_options(hermes_executor PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
   target_compile_options(hermes_executor PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
-
-  if (HERMES_V1_ENABLED)
-        target_compile_options(hermes_executor PRIVATE -DHERMES_V1_ENABLED=1)
-  endif()
 endif()

packages/react-native/ReactAndroid/src/main/jni/react/runtime/hermes/jni/CMakeLists.txt

@@ -29,8 +29,4 @@ target_link_libraries(hermesinstancejni
 target_compile_reactnative_options(hermesinstancejni PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
   target_compile_options(hermesinstancejni PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
-
-  if (HERMES_V1_ENABLED)
-        target_compile_options(hermesinstancejni PRIVATE -DHERMES_V1_ENABLED=1)
-  endif()
 endif ()

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/CMakeLists.txt

@@ -19,10 +19,6 @@ add_library(rninstance
 target_compile_reactnative_options(rninstance PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
   target_compile_options(rninstance PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
-
-  if (HERMES_V1_ENABLED)
-        target_compile_options(rninstance PRIVATE -DHERMES_V1_ENABLED=1)
-  endif()
 endif ()
 
 target_merge_so(rninstance)

packages/react-native/ReactCommon/cmake-utils/react-native-flags.cmake

@@ -32,4 +32,7 @@ function(target_compile_reactnative_options target_name scope)
   if(ANDROID)
     target_compile_definitions(${target_name} ${scope} RN_SERIALIZABLE_STATE)
   endif()
+  if(HERMES_V1_ENABLED)
+    target_compile_definitions(${target_name} ${scope} HERMES_V1_ENABLED=1)
+  endif()
 endfunction()

packages/react-native/ReactCommon/hermes/executor/CMakeLists.txt

@@ -32,10 +32,6 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
                 PRIVATE
                 -DHERMES_ENABLE_DEBUGGER=1
         )
-
-        if (HERMES_V1_ENABLED)
-                target_compile_options(hermes_executor_common PRIVATE -DHERMES_V1_ENABLED=1)
-        endif()
 else()
         target_compile_options(
                 hermes_executor_common

packages/react-native/ReactCommon/hermes/inspector-modern/CMakeLists.txt

@@ -23,10 +23,6 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
                 PRIVATE
                 -DHERMES_ENABLE_DEBUGGER=1
         )
-
-        if (HERMES_V1_ENABLED)
-                target_compile_options(hermes_inspector_modern PRIVATE -DHERMES_V1_ENABLED=1)
-        endif()
 endif()
 
 target_include_directories(hermes_inspector_modern PUBLIC ${REACT_COMMON_DIR})

packages/react-native/ReactCommon/react/runtime/CMakeLists.txt

@@ -18,10 +18,6 @@ add_library(bridgeless
 target_compile_reactnative_options(bridgeless PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
   target_compile_options(bridgeless PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
-
-  if (HERMES_V1_ENABLED)
-        target_compile_options(bridgeless PRIVATE -DHERMES_V1_ENABLED=1)
-  endif()
 endif ()
 target_include_directories(bridgeless PUBLIC .)
 

packages/react-native/ReactCommon/react/runtime/hermes/CMakeLists.txt

@@ -35,8 +35,4 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
                 PRIVATE
                 -DHERMES_ENABLE_DEBUGGER=1
         )
-
-        if (HERMES_V1_ENABLED)
-                target_compile_options(bridgelesshermes PRIVATE -DHERMES_V1_ENABLED=1)
-        endif()
 endif()