Skip to content

Commit 539e1b1

Browse files
committed
Issue#11068 PR#35929 [Android] Unify naming of introduced variables
Use Composing name everywhere instead of composite to ensure the intent is clear and its not confusing two different things together.
1 parent b499bd9 commit 539e1b1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

  • packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -632,12 +632,12 @@ public void maybeSetText(ReactTextUpdate reactTextUpdate) {
632632
if (reactTextUpdate.getText().length() == 0) {
633633
setText(null);
634634
} else {
635-
boolean shouldKeepCompositeSpan = length() == spannableStringBuilder.length();
635+
boolean shouldRestoreComposingSpans = length() == spannableStringBuilder.length();
636636

637637
getText().replace(0, length(), spannableStringBuilder);
638638

639-
if (shouldKeepCompositeSpan) {
640-
attachCompositeSpansToTextFrom(spannableStringBuilder);
639+
if (shouldRestoreComposingSpans) {
640+
restoreComposingSpansToTextFrom(spannableStringBuilder);
641641
}
642642
}
643643
mDisableTextDiffing = false;
@@ -823,7 +823,7 @@ private void addSpansFromStyleAttributes(SpannableStringBuilder workingText) {
823823
* See {@link ReactEditText#manageSpans} for more details.
824824
* Also https://github.com/facebook/react-native/issues/11068
825825
*/
826-
private void attachCompositeSpansToTextFrom(SpannableStringBuilder spannableStringBuilder) {
826+
private void restoreComposingSpansToTextFrom(SpannableStringBuilder spannableStringBuilder) {
827827
Editable text = getText();
828828
if (text == null) {
829829
return;

0 commit comments

Comments
 (0)