[Impeller] Null check for the device holder in the Vulkan context destructor (flutter#42821)

jason-simmons · web-flow · commit 94dc7ddbca63 · 2023-06-13T21:03:12.000Z
diff --git a/impeller/renderer/backend/vulkan/context_vk.cc b/impeller/renderer/backend/vulkan/context_vk.cc
@@ -107,7 +107,7 @@ uint64_t CalculateHash(void* ptr) {
 ContextVK::ContextVK() : hash_(CalculateHash(this)) {}
 
 ContextVK::~ContextVK() {
-  if (device_holder_->device) {
+  if (device_holder_ && device_holder_->device) {
     [[maybe_unused]] auto result = device_holder_->device->waitIdle();
   }
   CommandPoolVK::ClearAllPools(this);

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ uint64_t CalculateHash(void* ptr) {`
`107`	`107`	`ContextVK::ContextVK() : hash_(CalculateHash(this)) {}`
`108`	`108`
`109`	`109`	`ContextVK::~ContextVK() {`
`110`		`- if (device_holder_->device) {`
	`110`	`+ if (device_holder_ && device_holder_->device) {`
`111`	`111`	`[[maybe_unused]] auto result = device_holder_->device->waitIdle();`
`112`	`112`	`}`
`113`	`113`	`CommandPoolVK::ClearAllPools(this);`