Roll Clang to 80743bd43fd5b38fedc503308e7a652e23d3ec93 (flutter#182919)

jason-simmons · web-flow · commit 3f400d7c69e1 · 2026-03-11T13:50:32.000Z
Fixes flutter#182781
diff --git a/DEPS b/DEPS
@@ -43,7 +43,7 @@ vars = {
   # updates to Clang Tidy will not turn the tree red.
   #
   # See https://github.com/flutter/flutter/wiki/Engine-pre‐submits-and-post‐submits#post-submit
-  'clang_version': 'git_revision:8c7a2ce01a77c96028fe2c8566f65c45ad9408d3',
+  'clang_version': 'git_revision:80743bd43fd5b38fedc503308e7a652e23d3ec93',
 
   'reclient_version': 're_client_version:0.185.0.db415f21-gomaip',
 
@@ -515,7 +515,7 @@ deps = {
   Var('swiftshader_git') + '/SwiftShader.git' + '@' + '794b0cfce1d828d187637e6d932bae484fbe0976',
 
   'engine/src/flutter/third_party/angle':
-  Var('flutter_git') + '/third_party/angle' + '@' + 'ad5b0084fe6b7606fe87d38f60fddf3cea45a685',
+  Var('flutter_git') + '/third_party/angle' + '@' + '84027aca9b71c9ba335bd000dad1107b8810a511',
 
   'engine/src/flutter/third_party/vulkan_memory_allocator':
   Var('chromium_git') + '/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator' + '@' + 'c788c52156f3ef7bc7ab769cb03c110a53ac8fcb',
@@ -764,7 +764,7 @@ deps = {
     'packages': [
       {
         'package': 'flutter_internal/rbe/reclient_cfgs',
-        'version': 'LNMZdvF2Y86Dq05IWthtVJ_PswIFSRiywIHrkfHhelUC',
+        'version': '0vARzGeIZgIhW7zVfWuqIPQ_HXMLDccjAstykWZKjaEC',
       }
     ],
     'condition': 'use_rbe',
diff --git a/engine/src/flutter/build/secondary/flutter/third_party/harfbuzz/BUILD.gn b/engine/src/flutter/build/secondary/flutter/third_party/harfbuzz/BUILD.gn
@@ -13,6 +13,10 @@ config("harfbuzz_flags") {
       "-Wno-missing-field-initializers",
       "-Wno-unused-variable",
       "-Wno-sign-compare",
+
+      # Workaround for an incompatibility with current versions of Clang
+      # (see https://github.com/harfbuzz/harfbuzz/issues/5738)
+      "-Wno-array-bounds",
     ]
   }
 
diff --git a/engine/src/flutter/display_list/dl_op_records.h b/engine/src/flutter/display_list/dl_op_records.h
@@ -68,17 +68,15 @@ struct DLOp {
 };
 
 // 4 byte header + 4 byte payload packs into minimum 8 bytes
-#define DEFINE_SET_BOOL_OP(name)                                      \
-  struct Set##name##Op final : DLOp {                                 \
-    static constexpr auto kType = DisplayListOpType::kSet##name;      \
-                                                                      \
-    explicit Set##name##Op(bool value) : DLOp(kType), value(value) {} \
-                                                                      \
-    const bool value;                                                 \
-                                                                      \
-    void dispatch(DlOpReceiver& receiver) const {                     \
-      receiver.set##name(value);                                      \
-    }                                                                 \
+#define DEFINE_SET_BOOL_OP(name)                                               \
+  struct Set##name##Op final : DLOp {                                          \
+    static constexpr auto kType = DisplayListOpType::kSet##name;               \
+                                                                               \
+    explicit Set##name##Op(bool value) : DLOp(kType), value(value) {}          \
+                                                                               \
+    const bool value;                                                          \
+                                                                               \
+    void dispatch(DlOpReceiver& receiver) const { receiver.set##name(value); } \
   };
 DEFINE_SET_BOOL_OP(AntiAlias)
 DEFINE_SET_BOOL_OP(InvertColors)
diff --git a/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc b/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc
@@ -184,8 +184,9 @@ TEST_F(PerformanceOverlayLayerTest, InvalidOptions) {
   const uint64_t overlay_opts = 0;
   auto layer = std::make_shared<PerformanceOverlayLayer>(overlay_opts);
 
-  // TODO(): Note calling code has to call set_paint_bounds right now.  Make
-  // this a constructor parameter and move the set_paint_bounds into Preroll
+  // TODO(team-engine): Note calling code has to call set_paint_bounds right
+  // now.  Make this a constructor parameter and move the set_paint_bounds
+  // into Preroll
   layer->set_paint_bounds(layer_bounds);
 
   layer->Preroll(preroll_context());
@@ -207,8 +208,9 @@ TEST_F(PerformanceOverlayLayerTest, SimpleRasterizerStatistics) {
   auto layer = std::make_shared<PerformanceOverlayLayer>(overlay_opts);
   auto font = PerformanceOverlayLayer::MakeStatisticsFont("");
 
-  // TODO(): Note calling code has to call set_paint_bounds right now.  Make
-  // this a constructor parameter and move the set_paint_bounds into Preroll
+  // TODO(team-engine): Note calling code has to call set_paint_bounds right
+  // now.  Make this a constructor parameter and move the set_paint_bounds
+  // into Preroll
   layer->set_paint_bounds(layer_bounds);
 
   layer->Preroll(preroll_context());
diff --git a/engine/src/flutter/impeller/display_list/aiks_dl_atlas_unittests.cc b/engine/src/flutter/impeller/display_list/aiks_dl_atlas_unittests.cc
@@ -33,7 +33,8 @@ RSTransform MakeTranslation(Scalar tx, Scalar ty) {
 
 std::tuple<std::vector<DlRect>,       //
            std::vector<RSTransform>,  //
-           sk_sp<DlImageImpeller>> CreateTestData(const AiksTest* test) {
+           sk_sp<DlImageImpeller>>
+CreateTestData(const AiksTest* test) {
   // Draws the image as four squares stiched together.
   auto atlas =
       DlImageImpeller::Make(test->CreateTextureForFixture("bay_bridge.jpg"));
diff --git a/engine/src/flutter/impeller/renderer/pipeline_compile_queue.h b/engine/src/flutter/impeller/renderer/pipeline_compile_queue.h
@@ -45,7 +45,7 @@ class PipelineCompileQueue final
   static std::shared_ptr<PipelineCompileQueue> Create(
       std::shared_ptr<fml::ConcurrentTaskRunner> worker_task_runner);
 
-  virtual ~PipelineCompileQueue();
+  ~PipelineCompileQueue();
 
   PipelineCompileQueue(const PipelineCompileQueue&) = delete;
 
diff --git a/engine/src/flutter/impeller/toolkit/android/toolkit_android_unittests.cc b/engine/src/flutter/impeller/toolkit/android/toolkit_android_unittests.cc
@@ -12,16 +12,14 @@
 
 namespace impeller::android::testing {
 
-#define DISABLE_ANDROID_PROC(name)                 \
-  struct Disable##name {                           \
-    Disable##name() {                              \
-      real_proc = GetMutableProcTable().name.proc; \
-      GetMutableProcTable().name.proc = nullptr;   \
-    }                                              \
-    ~Disable##name() {                             \
-      GetMutableProcTable().name.proc = real_proc; \
-    }                                              \
-    decltype(name)* real_proc;                     \
+#define DISABLE_ANDROID_PROC(name)                                    \
+  struct Disable##name {                                              \
+    Disable##name() {                                                 \
+      real_proc = GetMutableProcTable().name.proc;                    \
+      GetMutableProcTable().name.proc = nullptr;                      \
+    }                                                                 \
+    ~Disable##name() { GetMutableProcTable().name.proc = real_proc; } \
+    decltype(name)* real_proc;                                        \
   } disable##name;
 
 TEST(ToolkitAndroidTest, CanCreateProcTable) {
diff --git a/engine/src/flutter/shell/common/persistent_cache_unittests.cc b/engine/src/flutter/shell/common/persistent_cache_unittests.cc
@@ -191,7 +191,8 @@ TEST_F(PersistentCacheTest, PurgeAllowsFutureSkSLCache) {
   std::promise<bool> io_flushed;
   shell->GetTaskRunners().GetIOTaskRunner()->PostTask(
       [&io_flushed]() { io_flushed.set_value(true); });
-  io_flushed.get_future().get();  // Wait for the IO thread to flush the file.
+  // Wait for the IO thread to flush the file.
+  EXPECT_TRUE(io_flushed.get_future().get());
   ASSERT_GT(persistent_cache->LoadSkSLs().size(), 0u);
 
   // Cleanup
diff --git a/engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterChannels.mm b/engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterChannels.mm
@@ -53,9 +53,11 @@ static FlutterBinaryMessengerConnection SetMessageHandler(
     FlutterBinaryMessageHandler handler,
     NSObject<FlutterTaskQueue>* taskQueue) {
   if (taskQueue) {
-    NSCAssert([messenger respondsToSelector:@selector(setMessageHandlerOnChannel:
-                                                            binaryMessageHandler:taskQueue:)],
-              @"");
+    NSCAssert(
+        [messenger
+            respondsToSelector:@selector(
+                                   setMessageHandlerOnChannel:binaryMessageHandler:taskQueue:)],
+        @"");
     return [messenger setMessageHandlerOnChannel:name
                             binaryMessageHandler:handler
                                        taskQueue:taskQueue];
diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm
@@ -615,8 +615,9 @@ - (BOOL)application:(UIApplication*)application
     if (!delegate || (isFallback && [self pluginSupportsSceneLifecycle:delegate])) {
       continue;
     }
-    if ([delegate respondsToSelector:@selector(application:
-                                         performActionForShortcutItem:completionHandler:)]) {
+    if ([delegate
+            respondsToSelector:@selector(
+                                   application:performActionForShortcutItem:completionHandler:)]) {
       if ([delegate application:application
               performActionForShortcutItem:shortcutItem
                          completionHandler:completionHandler]) {
@@ -688,8 +689,8 @@ - (BOOL)application:(UIApplication*)application
     if (!delegate || (isFallback && [self pluginSupportsSceneLifecycle:delegate])) {
       continue;
     }
-    if ([delegate respondsToSelector:@selector(application:
-                                         continueUserActivity:restorationHandler:)]) {
+    if ([delegate
+            respondsToSelector:@selector(application:continueUserActivity:restorationHandler:)]) {
       if ([delegate application:application
               continueUserActivity:userActivity
                 restorationHandler:restorationHandler]) {
diff --git a/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc b/engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc
@@ -3647,7 +3647,7 @@ TEST_F(EmbedderTest, KeyDataAreBuffered) {
   };
 
   // Send an event.
-  sample_event.timestamp = 1.0l;
+  sample_event.timestamp = 1.0;
   platform_task_runner->PostTask([&]() {
     FlutterEngineSendKeyEvent(engine.get(), &sample_event, nullptr, nullptr);
     message_latch->Signal();
@@ -3685,7 +3685,7 @@ TEST_F(EmbedderTest, KeyDataAreBuffered) {
   EXPECT_EQ(echoed_events.size(), 1u);
 
   // Send a second event.
-  sample_event.timestamp = 10.0l;
+  sample_event.timestamp = 10.0;
   platform_task_runner->PostTask([&]() {
     FlutterEngineSendKeyEvent(engine.get(), &sample_event, nullptr, nullptr);
   });
diff --git a/engine/src/flutter/testing/display_list_testing.cc b/engine/src/flutter/testing/display_list_testing.cc
@@ -70,7 +70,7 @@ std::ostream& operator<<(std::ostream& os,
                          const DisplayList& display_list) {
   DisplayListStreamDispatcher dispatcher(os);
   os << std::boolalpha;
-  os << std::setprecision(std::numeric_limits<long double>::digits10 + 1);
+  os << std::setprecision(std::numeric_limits<double>::digits10 + 1);
   os << "DisplayList {" << std::endl;
   display_list.Dispatch(dispatcher);
   os << "}" << std::endl;
diff --git a/engine/src/flutter/third_party/accessibility/ax/ax_event_intent.h b/engine/src/flutter/third_party/accessibility/ax/ax_event_intent.h
@@ -21,7 +21,7 @@ struct AX_BASE_EXPORT AXEventIntent final {
   AXEventIntent(ax::mojom::Command command,
                 ax::mojom::TextBoundary text_boundary,
                 ax::mojom::MoveDirection move_direction);
-  virtual ~AXEventIntent();
+  ~AXEventIntent();
   AXEventIntent(const AXEventIntent& intent);
   AXEventIntent& operator=(const AXEventIntent& intent);
 
diff --git a/engine/src/flutter/third_party/accessibility/ax/ax_node.h b/engine/src/flutter/third_party/accessibility/ax/ax_node.h
@@ -103,7 +103,7 @@ class AX_EXPORT AXNode final {
          int32_t id,
          size_t index_in_parent,
          size_t unignored_index_in_parent = 0);
-  virtual ~AXNode();
+  ~AXNode();
 
   // Accessors.
   OwnerTree* tree() const { return tree_; }
diff --git a/engine/src/flutter/third_party/accessibility/ax/ax_relative_bounds.h b/engine/src/flutter/third_party/accessibility/ax/ax_relative_bounds.h
@@ -32,7 +32,7 @@ namespace ui {
 // to its immediate containing node.
 struct AX_BASE_EXPORT AXRelativeBounds final {
   AXRelativeBounds();
-  virtual ~AXRelativeBounds();
+  ~AXRelativeBounds();
 
   AXRelativeBounds(const AXRelativeBounds& other);
   AXRelativeBounds& operator=(AXRelativeBounds other);
diff --git a/engine/src/flutter/tools/licenses_cpp/src/license_checker.cc b/engine/src/flutter/tools/licenses_cpp/src/license_checker.cc
@@ -28,12 +28,12 @@ namespace fs = std::filesystem;
 const char* LicenseChecker::kHeaderLicenseRegex = "(?i)(license|copyright)";
 
 namespace {
-// TODO(): Move this into the data directory.
+// TODO(gaaclarke): Move this into the data directory.
 const std::array<std::string_view, 9> kLicenseFileNames = {
     "LICENSE", "LICENSE.TXT", "LICENSE.txt",  "LICENSE.md", "LICENSE.MIT",
     "COPYING", "License.txt", "docs/FTL.TXT", "README.ijg"};
 
-// TODO(): Move this into the data directory
+// TODO(gaaclarke): Move this into the data directory
 //  These are directories that when they are found in third_party directories
 //  are ignored as package names.
 const std::array<std::string_view, 2> kThirdPartyIgnore = {"pkg",

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,10 @@ config("harfbuzz_flags") {`
`13`	`13`	`"-Wno-missing-field-initializers",`
`14`	`14`	`"-Wno-unused-variable",`
`15`	`15`	`"-Wno-sign-compare",`
	`16`	`+`
	`17`	`+ # Workaround for an incompatibility with current versions of Clang`
	`18`	`+ # (see https://github.com/harfbuzz/harfbuzz/issues/5738)`
	`19`	`+ "-Wno-array-bounds",`
`16`	`20`	`]`
`17`	`21`	`}`
`18`	`22`