Commit 1592b60
authored
[macOS] Remove FlutterApplication class (flutter#40939)
The need for the FlutterApplication NSApplication subclass was
eliminated in 8679b67. The relevant app
termination logic was moved into FlutterAppDelegate in that patch.
Removing FlutterApplication needs to be done in three stages:
1. Migrate logic to FlutterAppDelegate (done in above patch)
2. Update Flutter tool template. Update migrator to migrate all apps
using FlutterApplication back to NSApplication. This is done in
flutter#124173.
3. Eliminate FlutterApplication.h header since all references to it have
now been removed.
No tests since, as described above, this is the removal of unused (as of
step 2 above) code.
Issue: flutter#30735
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat1 parent 3f6a278 commit 1592b60
5 files changed
Lines changed: 0 additions & 62 deletions
File tree
- ci/licenses_golden
- shell/platform/darwin/macos
- framework
- Headers
- Source
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2603 | 2603 | | |
2604 | 2604 | | |
2605 | 2605 | | |
2606 | | - | |
2607 | 2606 | | |
2608 | 2607 | | |
2609 | 2608 | | |
| |||
2616 | 2615 | | |
2617 | 2616 | | |
2618 | 2617 | | |
2619 | | - | |
2620 | 2618 | | |
2621 | 2619 | | |
2622 | 2620 | | |
| |||
5196 | 5194 | | |
5197 | 5195 | | |
5198 | 5196 | | |
5199 | | - | |
5200 | 5197 | | |
5201 | 5198 | | |
5202 | 5199 | | |
| |||
5210 | 5207 | | |
5211 | 5208 | | |
5212 | 5209 | | |
5213 | | - | |
5214 | 5210 | | |
5215 | 5211 | | |
5216 | 5212 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | | - | |
62 | 60 | | |
63 | 61 | | |
64 | 62 | | |
| |||
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
Lines changed: 0 additions & 8 deletions
This file was deleted.
0 commit comments