Skip to content

fix: allow EggConsoleLogger init without options - #90

Merged
fengmk2 merged 2 commits into
masterfrom
fix-EggConsoleLogger-options
Jun 5, 2023
Merged

fengmk2 merged 2 commits into
masterfrom
fix-EggConsoleLogger-options

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 4, 2023

Copy link
Copy Markdown
Member
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 added the bug label Jun 4, 2023
Comment thread index.d.ts
export class EggErrorLogger extends Logger {}
export class EggConsoleLogger extends Logger {}
export class EggConsoleLogger<T = LoggerOptions> extends Logger {
constructor(options?: T);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@codecov

codecov Bot commented Jun 4, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (14919d8) 98.69% compared to head (1f7d942) 98.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          14       14           
  Lines        1307     1307           
  Branches      215      215           
=======================================
  Hits         1290     1290           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2
fengmk2 merged commit e4ff375 into master Jun 5, 2023
@fengmk2
fengmk2 deleted the fix-EggConsoleLogger-options branch June 5, 2023 00:35
fengmk2 pushed a commit that referenced this pull request Jun 5, 2023
[skip ci]

## [3.3.1](v3.3.0...v3.3.1) (2023-06-05)

### Bug Fixes

* allow EggConsoleLogger init without options ([#90](#90)) ([e4ff375](e4ff375))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant