GH-28: Added support for the super- and subtype hierarchies. by kittaakos · Pull Request #823 · eclipse-jdtls/eclipse.jdt.ls

kittaakos · 2018-10-09T07:55:19Z

Note: This item depends on eclipse-lsp4j/lsp4j#272 due to required API changes. Still, this PR is ready for review/preview. Done.

Closes: #28.

Signed-off-by: Akos Kitta kittaakos@typefox.io

For reviewers:

~~I start working on a client implementation, once it is available, I will update this PR.~~ A client implementation with Eclipse Theia is available here.
~~Why did I add org.eclipse.wst.xml_ui.feature.feature.group to the TP~~? The TP related change is not required anymore. See GH-28: Added support for the super- and subtype hierarchies. #823 (review).
- LSP4J depends on Xtext/Xtend 2.15.
- Xtext/Xtend 2.15 is not available from the http://download.eclipse.org/releases/photon/ p2 site.
- But org.jboss.tools.maven.apt.feature.feature.group depends on org.eclipse.wst.xml.ui that we used to pull from http://download.eclipse.org/releases/photon/ under the hood.
- I had to explicitly declare the org.eclipse.wst.xml_ui.feature.feature.group feature dependency to fulfill the missing o.e.wst.xml.ui plug-in.

Edit: Updated the section for the TP.

fbricon · 2018-11-20T04:52:29Z

        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
-            <unit id="org.eclipse.xtend.sdk.feature.group" version="2.14.0.v20180523-0937"/>
-            <unit id="org.eclipse.xtext.sdk.feature.group" version="2.14.0.v20180523-0937"/>
+            <unit id="org.eclipse.wst.xml_ui.feature.feature.group" version="3.10.0.v201804210200"/>


should not be necessary anymore, since we now only add the m2e-apt core bundle to the TP 74a0993

kittaakos · 2019-01-22T19:40:01Z

I have updated this PR based on the feedback we got for the LSP modifications.

I am currently experiencing build issues locally, it might be related to Xtext.

fbricon · 2019-01-22T19:46:31Z

How can I test it?

fbricon · 2019-01-22T19:59:02Z

+	 * The location, encapsulating the range enclosing this symbol not including
+	 * leading/trailing whitespace but everything else like comments.
+	 */
+	public static Location getFullLocation(IJavaElement element) throws JavaModelException {


similar static methods related to location computation live in JDTUtils. I reckon it's getting bloated over time, so we might get a dedicated LocationUtils class to handle all that

fbricon · 2019-01-22T20:00:19Z

+			return null;
+		}
+		try {
+			Location fullLocation = DocumentSymbolHandler.getFullLocation(type);


should not reference DocumentSymbolHandler here. use utility class instead

fbricon · 2019-01-22T20:01:48Z

+
+	public TypeHierarchyHandler(PreferenceManager preferenceManager) {
+		this.preferenceManager = preferenceManager;
+		enabled = Suppliers.memoize(() -> this.preferenceManager.getClientPreferences().isTypeHierarchySupported());


not convinced this simple call needs to be memoized

fbricon · 2019-01-22T20:04:58Z

you might want to change copyright headers for new files to 2019.

kittaakos · 2019-01-22T20:12:11Z

How can I test it?

It's not yet ready, sorry for the noise. I added the [WIP] tag to the title. I had to push to see if the build failure is local or not.

I will update this PR once more with some hints on how to try it.

kittaakos · 2019-01-25T16:18:58Z

How can I test it?

You can build it from source, but you need Python 2.x, yarn, etc.. or you could try to open it in Gitpod.

Once the build is finished, you can start the modified version of Theia with the adjusted JDT LS.
Execute the yarn --cwd ./examples/browser start --hostname 0.0.0.0 --port 3000 in the terminal.

Click on Open Browser and you have to wait a bit.
When you can see the welcome screen, you have to open a new terminal. It is either with Ctrl+Shift+` or from the Terminal > New Terminal menu.
Clone the JDT LS source by executing cd /workspace/ && git clone https://github.com/eclipse/eclipse.jdt.ls.git in the new terminal. (You can get any other Java source.)
Open a new workspace.
Once your workspace is up in Theia and the Java LS build has finished, open any Java files.
You can trigger the type hierarchy either with Ctrl/Cmd+Alt+H or from the editor's context menu.

Note, if the Type Hierarchy view is active, and has input, it will flip the type hierarchy direction.

If you have any question, or you stuck, let me know.

kittaakos · 2019-01-25T23:21:20Z

An easier way; here is Gitpod snapshot containing all the steps I have described above.
After clicking the link, select Open Browser from the top, and you can open (Ctrl/Cmd+P) any Java files from the workspace to try out the feature.

kittaakos · 2019-01-29T10:06:52Z

+	 */
+	private TypeHierarchyItem shallowCopy(TypeHierarchyItem other) {
+		TypeHierarchyItem copy = new TypeHierarchyItem();
+		other.setName(other.getName());


FIXME: must be copy instead of other.

…ies. Closes: eclipse-jdtls#28. Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos · 2019-03-05T10:26:55Z

I have rebased this PR from the master and updated the LSP4J dependency from 0.6.0 to 0.7.0. I also made the necessary API changes due to the LSP modifications. This PR is ready for the review.

Please note, although the proposed LSP extension has not been accepted by MS yet, this PR complies the proposed changes.

yudar1024 · 2019-10-02T06:09:32Z

wait this feature long time.

yudar1024 · 2019-10-19T01:38:43Z

@fbricon can some one handle the confilict files? wait this feature long time?

fbricon · 2019-10-24T18:05:10Z

@yudar1024 I want to wait for the spec to be finalized before merging this feature. See microsoft/vscode-languageserver-node#426

yudar1024 · 2019-12-04T03:40:03Z

@fbricon can you merge first to let developer can use it in early time like clangd, merge it at this time or after spec be finalize, we both need change the code if the spec make some change. but if we merge at this time , at least it can make vsc more efficient early

CsCherrYY · 2021-01-08T02:41:44Z

Hi @kittaakos

Are you still interested in this feature? I think it's especially useful and I'm interested in it.

I found you closed microsoft/vscode-languageserver-node#426 which is a proposal of type hierarchy in LSP. Although it will not be available in LSP recently, VS Code allows extensions to contribute to the tree view and here is a sample.

We could put the type hierarchy in the tree view, use a private command to exchange data instead of LSP currently. What do you think about it?

CsCherrYY · 2021-01-14T06:59:32Z

@kittaakos @fbricon

I'm going to implement this feature and make it available first. In the future, we can move to LSP once it supports type hierarchy.

I notice the data models such as TypeHierarchyItem, TypeHierarchyParams and ResolveTypeHierarchyItemParams are available since lsp4j#273. I'd like to start with these models and use a delegate command to communicate between client and server.

In VS Code side, References Viewlet API offers an API to contribute to the reference view. Type hierarchy data can be shown in the reference view with this, just like how call hierarchy works today.

Do you have any comment or suggestion on this?

fbricon · 2021-04-16T23:35:05Z

Superseded by #1656

kittaakos mentioned this pull request Oct 9, 2018

Support for Type Hierarchy #28

Closed

kittaakos force-pushed the GH-28 branch 2 times, most recently from decc6f6 to 3efbce6 Compare October 11, 2018 14:08

This was referenced Oct 11, 2018

[WIP] Proposal for type hierarchy microsoft/vscode-languageserver-node#346

Closed

Proposal of the type hierarchy protocol extension. microsoft/vscode-languageserver-node#426

Closed

fbricon mentioned this pull request Oct 30, 2018

Provide a Java view redhat-developer/vscode-java#698

Open

yaohaizh mentioned this pull request Nov 1, 2018

缺少快捷键；Java development lacks shortcut keys redhat-developer/vscode-java#701

Closed

fbricon reviewed Nov 20, 2018

View reviewed changes

kittaakos force-pushed the GH-28 branch from 3efbce6 to 3533ab2 Compare January 22, 2019 19:22

fbricon reviewed Jan 22, 2019

View reviewed changes

Comment thread org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/TypeHierarchyHandler.java

fbricon reviewed Jan 22, 2019

View reviewed changes

Comment thread org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/TypeHierarchyHandler.java

fbricon reviewed Jan 22, 2019

View reviewed changes

kittaakos changed the title ~~GH-28: Added support for the super- and subtype hierarchies.~~ [WIP] GH-28: Added support for the super- and subtype hierarchies. Jan 22, 2019

fbricon reviewed Jan 22, 2019

View reviewed changes

Comment thread org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java

kittaakos force-pushed the GH-28 branch 4 times, most recently from 0b0783f to 7888ade Compare January 25, 2019 14:11

kittaakos changed the title ~~[WIP] GH-28: Added support for the super- and subtype hierarchies.~~ GH-28: Added support for the super- and subtype hierarchies. Jan 25, 2019

kittaakos commented Jan 29, 2019

View reviewed changes

eclipse-jdtlsGH-28: Added support for the super- and subtype hierarch…

3836c33

…ies. Closes: eclipse-jdtls#28. Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos force-pushed the GH-28 branch from 7888ade to 3836c33 Compare March 5, 2019 10:13

testforstephen mentioned this pull request May 28, 2019

Question: Java Class Hierarchy Navigation microsoft/vscode-java-pack#152

Closed

fbricon closed this Apr 16, 2021

Conversation

kittaakos commented Oct 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fbricon Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

kittaakos commented Jan 22, 2019

Uh oh!

fbricon commented Jan 22, 2019

Uh oh!

Uh oh!

Uh oh!

fbricon Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

fbricon Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

fbricon Jan 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fbricon commented Jan 22, 2019

Uh oh!

Uh oh!

kittaakos commented Jan 22, 2019

Uh oh!

kittaakos commented Jan 25, 2019

Uh oh!

kittaakos commented Jan 25, 2019

Uh oh!

kittaakos Jan 29, 2019

Choose a reason for hiding this comment

Uh oh!

kittaakos commented Mar 5, 2019

Uh oh!

yudar1024 commented Oct 2, 2019

Uh oh!

yudar1024 commented Oct 19, 2019

Uh oh!

fbricon commented Oct 24, 2019

Uh oh!

yudar1024 commented Dec 4, 2019

Uh oh!

CsCherrYY commented Jan 8, 2021

Uh oh!

CsCherrYY commented Jan 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fbricon commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kittaakos commented Oct 9, 2018 •

edited

Loading

fbricon Jan 22, 2019 •

edited

Loading

CsCherrYY commented Jan 14, 2021 •

edited

Loading